From: Felix Fietkau <nbd@openwrt.org>
To: greearb@candelatech.com
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: Limit number of pending skbs.
Date: Wed, 30 May 2012 01:23:47 +0200 [thread overview]
Message-ID: <4FC55A83.6030602@openwrt.org> (raw)
In-Reply-To: <1338332576-26427-1-git-send-email-greearb@candelatech.com>
On 2012-05-30 1:02 AM, greearb@candelatech.com wrote:
> From: Ben Greear <greearb@candelatech.com>
>
> Current code will allow any number of pending skbs, and
> this can OOM the system when used with something like
> the pktgen tool (which may not back off properly if
> queue is stopped).
>
> Possibly this is just a bug in our version of pktgen,
> but either way, it seems reasonable to add a limit
> so that it is not possible to go OOM in this manner.
>
> Signed-off-by: Ben Greear <greearb@candelatech.com>
Adding a module parameter in a workaround for a possibly broken module
seems a bit excessive to me.
Also, I'm not sure adding such a silent packet drop is a good idea. At
the very least, it should complain loudly to encourage people to fix the
actual bug instead of just papering over it.
When the driver cannot accept more packets, the queue stop should
prevent the network stack from spamming mac80211 with more packets. Your
pktgen seems to be ignoring this, so please fix it instead of adding
workarounds to mac80211.
- Felix
next prev parent reply other threads:[~2012-05-29 23:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-29 23:02 [PATCH] mac80211: Limit number of pending skbs greearb
2012-05-29 23:23 ` Felix Fietkau [this message]
2012-05-29 23:29 ` Ben Greear
2012-05-30 7:03 ` Johannes Berg
2012-05-30 16:04 ` Ben Greear
2012-05-30 16:09 ` Johannes Berg
2012-05-30 16:14 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC55A83.6030602@openwrt.org \
--to=nbd@openwrt.org \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).