Re: [RFC] cfg80211: Fix incompatible interfaces combination

[Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>]

Hi Johannes,

>
> No, initialization was incorrect -- this is better:
> http://p.sipsolutions.net/e5ab0f3e38f90d6d.txt
>

thanks a lot for the patch!
with the above patch ath9k seems be working fine with the single 
incompatible adhoc interface.
but i was just experimenting with ath9k(similar to iwlwifi having 
hw->wiphy->n_iface_combinations > 1) with this patch.

static const struct ieee80211_iface_limit a[] = {
         { .max = 2,     .types = BIT(NL80211_IFTYPE_STATION) },
};

static const struct ieee80211_iface_limit b[] = {
         { .max = 2,     .types = BIT(NL80211_IFTYPE_MESH_POINT) },
};

static const struct ieee80211_iface_combination if_comb[] = {
         {.limits = a,
         .n_limits = ARRAY_SIZE(a),
         .max_interfaces = 2,
         .num_different_channels = 1,
         },
         {.limits = b,
         .n_limits = ARRAY_SIZE(b),
         .max_interfaces = 2,
         .num_different_channels = 1,
         },

};

i could not add mesh interface if a managed interface is already there 
and vice versa. if this is the expected behavior, then fine.

dmesg
iteration 1: cfg80211_can_change_interface all_iftypes 4 and used_iftypes 84
iteration 2: cfg80211_can_change_interface all_iftypes 80 and 
used_iftypes 84


-- 
thanks,
shafi