* [PATCH 5/7] drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c: adjust suspicious bit operation
[not found] <1339018901-28439-1-git-send-email-Julia.Lawall@lip6.fr>
@ 2012-06-06 21:41 ` Julia Lawall
2012-06-06 23:43 ` Franky Lin
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2012-06-06 21:41 UTC (permalink / raw)
To: Brett Rudley
Cc: kernel-janitors, Roland Vossen, Arend van Spriel,
Franky (Zhenhui) Lin, Kan Yan, John W. Linville, linux-wireless,
netdev, linux-kernel, joe, Julia Lawall
From: Julia Lawall <Julia.Lawall@lip6.fr>
IRQF_TRIGGER_HIGH is 0x00000004, so it seems that & was intended rather than |.
This problem was found using Coccinelle (http://coccinelle.lip6.fr/).
Signed-off-by: Julia Lawall <julia@diku.dk>
---
drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c b/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c
index e2480d1..bed208f 100644
--- a/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c
+++ b/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c
@@ -91,7 +91,7 @@ int brcmf_sdio_intr_register(struct brcmf_sdio_dev *sdiodev)
/* redirect, configure ane enable io for interrupt signal */
data = SDIO_SEPINT_MASK | SDIO_SEPINT_OE;
- if (sdiodev->irq_flags | IRQF_TRIGGER_HIGH)
+ if (sdiodev->irq_flags & IRQF_TRIGGER_HIGH)
data |= SDIO_SEPINT_ACT_HI;
brcmf_sdio_regwb(sdiodev, SDIO_CCCR_BRCM_SEPINT, data, &ret);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 5/7] drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c: adjust suspicious bit operation
2012-06-06 21:41 ` [PATCH 5/7] drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c: adjust suspicious bit operation Julia Lawall
@ 2012-06-06 23:43 ` Franky Lin
0 siblings, 0 replies; 2+ messages in thread
From: Franky Lin @ 2012-06-06 23:43 UTC (permalink / raw)
To: Julia Lawall
Cc: Brett Rudley, kernel-janitors, Roland Vossen, Arend van Spriel,
Kan Yan, John W. Linville, linux-wireless, netdev, linux-kernel,
joe, Julia Lawall
On 06/06/2012 02:41 PM, Julia Lawall wrote:
> From: Julia Lawall<Julia.Lawall@lip6.fr>
>
> IRQF_TRIGGER_HIGH is 0x00000004, so it seems that& was intended rather than |.
>
> This problem was found using Coccinelle (http://coccinelle.lip6.fr/).
>
> Signed-off-by: Julia Lawall<julia@diku.dk>
Thanks, Julia. But this has already been fixed by Joe Perches [1] and
the patch has arrived at Linux wireless tree.
Franky
[1] https://lkml.org/lkml/2012/5/30/482
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-06-06 23:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1339018901-28439-1-git-send-email-Julia.Lawall@lip6.fr>
2012-06-06 21:41 ` [PATCH 5/7] drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c: adjust suspicious bit operation Julia Lawall
2012-06-06 23:43 ` Franky Lin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).