From: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
To: Sujith Manoharan <c_manoha@qca.qualcomm.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
Johannes Berg <johannes@sipsolutions.net>,
<linux-wireless@vger.kernel.org>, Joe Perches <joe@perches.com>
Subject: Re: [PATCH] mac80211: ratelimit few aggregated messages
Date: Thu, 7 Jun 2012 11:57:52 +0530 [thread overview]
Message-ID: <4FD049E8.3090201@qca.qualcomm.com> (raw)
In-Reply-To: <20432.18148.937220.807081@gargle.gargle.HOWL>
Hi Sujith,
On Thursday 07 June 2012 11:45 AM, Sujith Manoharan wrote:
> Mohammed Shafi Shajakhan wrote:
>> From: Mohammed Shafi Shajakhan<mohammed@qca.qualcomm.com>
>>
>> ratelimit few aggregation related messages, these messages
>> floods the log when aggregation is disabled in the AP(for some
>> wifi testcases) and we run traffic between STA and AP.
>> mac80211 gives up after 15 addba requests, but
>> ieee80211_start_tx_ba_session will be repeatedly called
>> by drivers rate control tx_status callback. These net_dbg_ratelimited
>> messages will be visible only when dynamic debug is enabled for
>> mac80211 module.
>
> I think the drivers need to be fixed. For ath9k, we probably need
> an intermediate state to track whether an ADDBA request is pending.
>
the timeout till the addba requests can be sent out is completely taken
care by mac80211 and we stop trying after a particular amount of time
which is also tracked by mac80211, these are just logs after sometime
--
thanks,
shafi
next prev parent reply other threads:[~2012-06-07 6:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-07 6:02 [PATCH] mac80211: ratelimit few aggregated messages Mohammed Shafi Shajakhan
2012-06-07 6:15 ` Sujith Manoharan
2012-06-07 6:27 ` Mohammed Shafi Shajakhan [this message]
2012-06-07 6:25 ` Joe Perches
2012-06-07 7:11 ` Mohammed Shafi Shajakhan
2012-06-07 7:24 ` Joe Perches
2012-06-07 7:37 ` Mohammed Shafi Shajakhan
2012-06-07 7:57 ` Joe Perches
2012-06-07 8:38 ` Mohammed Shafi Shajakhan
2012-06-07 19:52 ` Joe Perches
2012-06-13 4:59 ` Mohammed Shafi Shajakhan
2012-06-14 1:13 ` Joe Perches
2012-06-14 4:37 ` Mohammed Shafi Shajakhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD049E8.3090201@qca.qualcomm.com \
--to=mohammed@qca.qualcomm.com \
--cc=c_manoha@qca.qualcomm.com \
--cc=joe@perches.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).