Re: [PATCH] mac80211: ratelimit few aggregated messages

[Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>]

Hi Joe,

>>>
>>> I think there's one use of wiphy_dbg that could be a
>>> mac80211_ht_dbg without much loss.
>>>
>>> Maybe add "%s", wiphy_name() to the args there.
>>>
>>
>> sorry, i could not understand with wiphy_debug, with mac80211_ht_debug.
>> the later is for HT and aggregation related messages.
>
> It was an automatic conversion.
>
> Might as well unconvert it back too.
>
> $ git grep -E -A4 -n "ifdef CONFIG_MAC80211_HT_DEBUG" net/mac80211/rx.c
> net/mac80211/rx.c:635:#ifdef CONFIG_MAC80211_HT_DEBUG
> net/mac80211/rx.c-636-                  if (net_ratelimit())
> net/mac80211/rx.c-637-                          wiphy_debug(hw->wiphy,
> net/mac80211/rx.c-638-                                      "release an RX reorder frame due to timeout on earlier frames\n");
> net/mac80211/rx.c-639-#endif
>
> $ git blame -L635,+4 net/mac80211/rx.c
> aa0c8636 (Christian Lamparter 2010-08-05 01:36:04 +0200 635) #ifdef CONFIG_MAC80211_HT_DEBUG
> aa0c8636 (Christian Lamparter 2010-08-05 01:36:04 +0200 636)                    if (net_ratelimit())
> 0fb9a9ec (Joe Perches         2010-08-20 16:25:38 -0700 637)                            wiphy_debug(hw->wiphy,
> 0fb9a9ec (Joe Perches         2010-08-20 16:25:38 -0700 638)                                        "release an RX reorder fram
>
> $ git log -1 0fb9a9ec
> commit 0fb9a9ec27718fbf7fa3153bc94becefb716ceeb
> Author: Joe Perches<joe@perches.com>
> Date:   Fri Aug 20 16:25:38 2010 -0700
>
>      net/mac80211: Use wiphy_<level>
>
>      Standardize logging messages from
>          printk(KERN_<level>  "%s: " fmt , wiphy_name(foo), args);
>      to
>          wiphy_<level>(foo, fmt, args);
>
>      Signed-off-by: Joe Perches<joe@perches.com>
>      Signed-off-by: John W. Linville<linville@tuxdriver.com>
>
>

thanks(and brilliant!), in that rx.c we can convert it to 
mac80211_ht_debug. what about the other wiphy_debug messages, we would 
still retain them know

-- 
thanks,
shafi