From: Felix Fietkau <nbd@openwrt.org>
To: Sylvain Roger Rieunier <sylvain.roger.rieunier@gmail.com>
Cc: johannes@sipsolutions.net, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] minstrel_ht: enable frame aggregation for fixed rate
Date: Thu, 07 Jun 2012 16:06:29 +0200 [thread overview]
Message-ID: <4FD0B565.4090809@openwrt.org> (raw)
In-Reply-To: <1339077677-5836-1-git-send-email-sylvain.roger.rieunier@gmail.com>
On 2012-06-07 4:01 PM, Sylvain Roger Rieunier wrote:
> Signed-off-by: Sylvain Roger Rieunier <sylvain.roger.rieunier@gmail.com>
> ---
> net/mac80211/rc80211_minstrel_ht.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/net/mac80211/rc80211_minstrel_ht.c b/net/mac80211/rc80211_minstrel_ht.c
> index 2d1acc6..e2aa93e 100644
> --- a/net/mac80211/rc80211_minstrel_ht.c
> +++ b/net/mac80211/rc80211_minstrel_ht.c
> @@ -626,8 +626,10 @@ minstrel_ht_get_rate(void *priv, struct ieee80211_sta *sta, void *priv_sta,
>
> #ifdef CONFIG_MAC80211_DEBUGFS
> /* use fixed index if set */
> - if (mp->fixed_rate_idx != -1)
> - sample_idx = mp->fixed_rate_idx;
> + if (mp->fixed_rate_idx != -1) {
> + mi->max_tp_rate = mp->fixed_rate_idx;
> + sample_idx = -1;
> + }
> #endif
I just noticed another issue, you should prevent minstrel_ht from
setting up the alternate retry chains if fixed rate is set, otherwise it
won't always use the rate you configured.
- Felix
next prev parent reply other threads:[~2012-06-07 14:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-07 14:01 [PATCH] minstrel_ht: enable frame aggregation for fixed rate Sylvain Roger Rieunier
2012-06-07 14:06 ` Felix Fietkau [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-06-07 15:39 Sylvain Roger Rieunier
2012-06-07 10:44 Sylvain Roger Rieunier
2012-06-07 11:51 ` Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD0B565.4090809@openwrt.org \
--to=nbd@openwrt.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=sylvain.roger.rieunier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).