From: Kalle Valo <kvalo@qca.qualcomm.com>
To: "Pedersen, Thomas" <c_tpeder@qca.qualcomm.com>
Cc: <linux-wireless@vger.kernel.org>, <johannes@sipsolutions.net>,
<ath6kl-devel@qualcomm.com>
Subject: Re: [RFC 1/2] nl80211: specify RSSI threshold when scanning
Date: Thu, 7 Jun 2012 21:53:20 +0300 [thread overview]
Message-ID: <4FD0F8A0.3000704@qca.qualcomm.com> (raw)
In-Reply-To: <20120607183820.GA2950@pista>
On 06/07/2012 09:38 PM, Pedersen, Thomas wrote:
>>> + WIPHY_FLAG_SUPPORTS_RSSI_SCAN = BIT(22),
>>> > > };
>> >
>> > Is this flag really needed? For me this looks like an optimisation more
>> > than a functional change. If the driver supports this, that's great and
>> > we can save some power. But if the driver does not support it does it
>> > really make any difference for the user space? Would user space act
>> > differently if this feature is not supported by the driver?
>
> Well, this allows cfg80211 to return an error if this feature is
> requested but not supported by the driver / fw.
But do we want to return an error when the driver doesn't support this?
I was thinking that driver should just ignore the attribute in that case
and let user space filter the results.
Kalle
next prev parent reply other threads:[~2012-06-07 18:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-07 2:43 [RFC 1/2] nl80211: specify RSSI threshold when scanning Thomas Pedersen
2012-06-07 2:43 ` [RFC 2/2] mac80211: support rssi threshold scan Thomas Pedersen
2012-06-07 7:25 ` Kalle Valo
2012-06-09 8:09 ` Johannes Berg
2012-06-09 22:03 ` Pedersen, Thomas
2012-06-10 8:11 ` Kalle Valo
2012-06-07 7:23 ` [RFC 1/2] nl80211: specify RSSI threshold when scanning Kalle Valo
2012-06-07 18:38 ` Pedersen, Thomas
2012-06-07 18:53 ` Kalle Valo [this message]
2012-06-07 19:18 ` Pedersen, Thomas
2012-06-09 8:09 ` Johannes Berg
2012-06-10 9:50 ` Luciano Coelho
2012-06-07 15:50 ` Dan Williams
2012-06-07 17:50 ` Kalle Valo
2012-06-11 5:39 ` Luciano Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD0F8A0.3000704@qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath6kl-devel@qualcomm.com \
--cc=c_tpeder@qca.qualcomm.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).