From: Kalle Valo <kvalo@qca.qualcomm.com>
To: "Pedersen, Thomas" <c_tpeder@qca.qualcomm.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
<linux-wireless@vger.kernel.org>, <ath6kl-devel@qualcomm.com>
Subject: Re: [RFC 2/2] mac80211: support rssi threshold scan
Date: Sun, 10 Jun 2012 11:11:20 +0300 [thread overview]
Message-ID: <4FD456A8.5030702@qca.qualcomm.com> (raw)
In-Reply-To: <20120609220310.GA3185@pista>
On 06/10/2012 01:03 AM, Pedersen, Thomas wrote:
> On Sat, Jun 09, 2012 at 10:09:52AM +0200, Johannes Berg wrote:
>> On Wed, 2012-06-06 at 19:43 -0700, Thomas Pedersen wrote:
>>
>>> + if (sdata->local->scan_req->rssi &&
>>> + rx_status->signal < sdata->local->scan_req->rssi)
>>> + return RX_DROP_MONITOR;
>>
>> I believe that should be RX_CONTINUE
>
> Thanks. Since this is considered a performance optimization, it makes
> little sense to even implement it in mac80211?
It doesn't do any harm either and on the positive side the feature will
be tested with all mac80211 drivers. But other than that there's no real
advantage.
Well, there's a theoretical advantage once we implement partial scan
results which would avoid waking up user space unnecessary. But I doubt
it makes any difference in practise.
But I still vote to take this patch, just to make the feature supported
with a wider range of drivers.
Kalle
next prev parent reply other threads:[~2012-06-10 8:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-07 2:43 [RFC 1/2] nl80211: specify RSSI threshold when scanning Thomas Pedersen
2012-06-07 2:43 ` [RFC 2/2] mac80211: support rssi threshold scan Thomas Pedersen
2012-06-07 7:25 ` Kalle Valo
2012-06-09 8:09 ` Johannes Berg
2012-06-09 22:03 ` Pedersen, Thomas
2012-06-10 8:11 ` Kalle Valo [this message]
2012-06-07 7:23 ` [RFC 1/2] nl80211: specify RSSI threshold when scanning Kalle Valo
2012-06-07 18:38 ` Pedersen, Thomas
2012-06-07 18:53 ` Kalle Valo
2012-06-07 19:18 ` Pedersen, Thomas
2012-06-09 8:09 ` Johannes Berg
2012-06-10 9:50 ` Luciano Coelho
2012-06-07 15:50 ` Dan Williams
2012-06-07 17:50 ` Kalle Valo
2012-06-11 5:39 ` Luciano Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD456A8.5030702@qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath6kl-devel@qualcomm.com \
--cc=c_tpeder@qca.qualcomm.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).