Re: [PATCH v2] minstrel_ht: enable frame aggregation for fixed rate

[sylvain_gmail <sylvain.roger.rieunier@gmail.com>]

Dear Johannes ans Felix,

This is my new change log version :

"This patch adds frame aggregation for fixed rate mode through debugfs.
Instead of using sample_idx, which set IEEE80211_TX_CTL_RATE_CTRL_PROBE 
flag,
which disabled frame aggregation, we set max_tp_rate and max_tp_rate2 which
  do not disable frame aggregation."

What's is your opinion?

Sylvain

Le 11/06/2012 16:58, Johannes Berg a écrit :
> On Mon, 2012-06-11 at 16:51 +0200, sylvain_gmail wrote:
>> Dear Johannes and Felix ,
>>
>> Here is the description of my patch that I can offer :
>>
>> "After trying to fix rate control with minstrel_ht. I realized that,
>> that fix rate was not allowed to make frames aggregation.
>> This was due to enable  IEEE80211_TX_CTL_RATE_CTRL_PROBE flag of the
>> ieee80211_tx_info structure.
>> Because when IEEE80211_TX_CTL_RATE_CTRL_PROBE flag is set frame
>> aggregation is disabled.
>>   So instead of used sample_idx, who set
>> IEEE80211_TX_CTL_RATE_CTRL_PROBE flag. I suggest using max_tp_rate and
>> max_tp_rate2 which do not disabled frame aggregation."
>>
>> what is your opinion?
> Makes more sense than before, but isn't really a viable changelog entry
> yet :)
>
> johannes
>