From: Pontus Fuchs <pontus.fuchs@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: Disallow changing chan type on monitor when CHAN_MODE_FIXED
Date: Tue, 12 Jun 2012 13:20:31 +0200 [thread overview]
Message-ID: <4FD725FF.1030108@gmail.com> (raw)
In-Reply-To: <1339499291.4531.1.camel@jlt3.sipsolutions.net>
On 2012-06-12 13:08, Johannes Berg wrote:
> If you add a monitor interface in paralell to a normal interface
> mac80211 will let you to change the channel type on the monitor
> interface even if you are connected. Add an explicit check to
> disallow this.
> Is this against 3.5, and is it really needed there? It's a corner case
> to start with.
It's against wireless-next. It's a real corner case indeed. With the
wireshark toolbar I create monitors on demand for all phy's so I
see it quite often myself. If it needs fixing is up to you to decide :)
Cheers,
Pontus
next prev parent reply other threads:[~2012-06-12 11:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-12 11:06 [PATCH] mac80211: Disallow changing chan type on monitor when CHAN_MODE_FIXED Pontus Fuchs
2012-06-12 11:08 ` Johannes Berg
2012-06-12 11:20 ` Pontus Fuchs [this message]
2012-06-12 11:33 ` Johannes Berg
2012-06-12 12:15 ` Pontus Fuchs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD725FF.1030108@gmail.com \
--to=pontus.fuchs@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).