From: Will Hawkins <hawkinsw@opentechinstitute.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: add support for userspace to handle auth frames on adhoc ifaces
Date: Thu, 14 Jun 2012 12:45:23 -0400 [thread overview]
Message-ID: <4FDA1523.7090301@opentechinstitute.org> (raw)
In-Reply-To: <1339658006.4909.3.camel@jlt3.sipsolutions.net>
On 06/14/2012 03:13 AM, Johannes Berg wrote:
> On Wed, 2012-06-13 at 11:46 -0400, Will Hawkins wrote:
>> Hello all!
>>
>> This patch allows userspace applications to use nl80211 to register for
>> AUTH frames received on adhoc interfaces.
>>
>> Thanks,
>> Will
>>
>> Signed-off-by: Will Hawkins <hawkinsw@opentechinstitute.org>
>
> Thanks for the patch. Can I get you to write a better commit log? :-)
>
> You should remove the "Hello" and "Thanks" portions, they shouldn't go
> into the kernel's commit log after all. And then, even if I already
> know, please explain in the commit log why you're making this change so
> the reason gets recorded in the kernel's commit log.
I submitted a v2 of this patch with a better commit log. Thanks for the
handholding. I'm obviously still new at this!
Will
>
> Thanks,
> johannes
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2012-06-14 16:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-13 15:46 [PATCH] mac80211: add support for userspace to handle auth frames on adhoc ifaces Will Hawkins
2012-06-14 7:13 ` Johannes Berg
2012-06-14 16:45 ` Will Hawkins [this message]
2012-06-14 8:00 ` Nicolas Cavallari
2012-06-14 11:24 ` Johannes Berg
2012-06-14 12:46 ` Nicolas Cavallari
2012-06-14 16:48 ` Will Hawkins
2012-06-14 16:53 ` Johannes Berg
2012-06-14 16:55 ` Will Hawkins
2012-06-14 17:08 ` Johannes Berg
2012-06-14 18:26 ` Will Hawkins
2012-06-14 18:51 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FDA1523.7090301@opentechinstitute.org \
--to=hawkinsw@opentechinstitute.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).