From: Felix Fietkau <nbd@openwrt.org>
To: Rajkumar Manoharan <rmanohar@qca.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com,
rodrigue@qca.qualcomm.com, c_manoha@qca.qualcomm.com
Subject: Re: [PATCH 4/9] ath9k_hw: clean up / fix ANI mode checks related to beacon RSSI
Date: Fri, 15 Jun 2012 23:05:50 +0200 [thread overview]
Message-ID: <4FDBA3AE.9040009@openwrt.org> (raw)
In-Reply-To: <20120615174916.GB648@vmraj-lnx.qca.qualcomm.com>
On 2012-06-15 7:49 PM, Rajkumar Manoharan wrote:
> On Fri, Jun 15, 2012 at 03:25:22PM +0200, Felix Fietkau wrote:
>> Beacon RSSI is only meaningful in station mode - in ad-hoc mode it
>> fluctuates, depending on which peer last sent a beacon, and in other
>> modes it is not set at all.
>> Fix places in ANI where the beacon RSSI is used to limit their use
>> to station mode only.
>>
>> Signed-off-by: Felix Fietkau <nbd@openwrt.org>
>> ---
>> drivers/net/wireless/ath/ath9k/ani.c | 12 +++++-------
>> 1 files changed, 5 insertions(+), 7 deletions(-)
>>
> If so, we should not update beacon rssi in process_rssi in IBSS
> mode.
OK, that can be taken care of in a followup patch.
- Felix
next prev parent reply other threads:[~2012-06-15 21:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-15 13:25 [PATCH 1/9] ath9k_hw: remove aniState->noiseFloor Felix Fietkau
2012-06-15 13:25 ` [PATCH 2/9] ath9k_hw: fix OFDM weak signal detection handling Felix Fietkau
2012-06-15 13:25 ` [PATCH 3/9] ath9k_hw: remove confusing logic inversion in an ANI variable Felix Fietkau
2012-06-15 13:25 ` [PATCH 4/9] ath9k_hw: clean up / fix ANI mode checks related to beacon RSSI Felix Fietkau
2012-06-15 13:25 ` [PATCH 5/9] ath9k_hw: remove the old ANI implementation Felix Fietkau
2012-06-15 13:25 ` [PATCH 6/9] ath9k_hw: clean up defines and variables from the ANI implementation split Felix Fietkau
2012-06-15 13:25 ` [PATCH 7/9] ath9k: remove MIB interrupt support Felix Fietkau
2012-06-15 13:25 ` [PATCH 8/9] ath9k_hw: fix setting lower noise immunity values Felix Fietkau
2012-06-15 13:25 ` [PATCH 9/9] ath9k_hw: clean up ANI OFDM trigger handling Felix Fietkau
2012-06-15 18:05 ` [PATCH 8/9] ath9k_hw: fix setting lower noise immunity values Rajkumar Manoharan
2012-06-15 17:58 ` [PATCH 5/9] ath9k_hw: remove the old ANI implementation Rajkumar Manoharan
2012-06-15 21:09 ` Felix Fietkau
2012-06-17 1:06 ` Sujith Manoharan
2012-06-17 14:36 ` Felix Fietkau
2012-06-18 8:36 ` Sujith Manoharan
2012-06-18 10:12 ` Sujith Manoharan
2012-06-15 17:49 ` [PATCH 4/9] ath9k_hw: clean up / fix ANI mode checks related to beacon RSSI Rajkumar Manoharan
2012-06-15 21:05 ` Felix Fietkau [this message]
2012-06-15 17:38 ` [PATCH 2/9] ath9k_hw: fix OFDM weak signal detection handling Rajkumar Manoharan
2012-06-15 21:05 ` Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FDBA3AE.9040009@openwrt.org \
--to=nbd@openwrt.org \
--cc=c_manoha@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=rmanohar@qca.qualcomm.com \
--cc=rodrigue@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).