From: Felix Fietkau <nbd@openwrt.org>
To: Rajkumar Manoharan <rmanohar@qca.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com,
rodrigue@qca.qualcomm.com, c_manoha@qca.qualcomm.com
Subject: Re: [PATCH 5/9] ath9k_hw: remove the old ANI implementation
Date: Fri, 15 Jun 2012 23:09:15 +0200 [thread overview]
Message-ID: <4FDBA47B.7070709@openwrt.org> (raw)
In-Reply-To: <20120615175810.GC648@vmraj-lnx.qca.qualcomm.com>
On 2012-06-15 7:58 PM, Rajkumar Manoharan wrote:
> On Fri, Jun 15, 2012 at 03:25:23PM +0200, Felix Fietkau wrote:
>> It was found to be buggy on a variety of chipsets from AR913x to AR928x.
>> The new version (which was introduced along with AR93xx support) is more
>> reliable in preventing connectivity dropouts and also fixes MIB interrupt
>> storm issues.
>>
>> Signed-off-by: Felix Fietkau <nbd@openwrt.org>
>
> I dont think it is good idea to completely removing old ANI for all AR9002
> family chips. No one have ever tested the new ANI with all ar9002 chips. May
> be there could be some regressions with old ANI. As we discussed in irc did
> you get any feedback from openwrt users with partial revert patch? So it is
> not viable to wipe out old ani support for older chips.
Several OpenWrt users have tested this on various AR9001 and AR9002
devices and have reported a very significant increase in stability in a
variety of environments. Sure, this needs a bit more testing, but the
old code is known broken in many ways, yet at the same time a bit too
convoluted for proper bug analysis.
I think removing the old code is our best option for having a chance to
again be able to fully understand the code and its various side effects.
Leaving the old code in place just makes it more likely for regressions
to show up when the new code is improved (as has already happened on
several occasions).
- Felix
next prev parent reply other threads:[~2012-06-15 21:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-15 13:25 [PATCH 1/9] ath9k_hw: remove aniState->noiseFloor Felix Fietkau
2012-06-15 13:25 ` [PATCH 2/9] ath9k_hw: fix OFDM weak signal detection handling Felix Fietkau
2012-06-15 13:25 ` [PATCH 3/9] ath9k_hw: remove confusing logic inversion in an ANI variable Felix Fietkau
2012-06-15 13:25 ` [PATCH 4/9] ath9k_hw: clean up / fix ANI mode checks related to beacon RSSI Felix Fietkau
2012-06-15 13:25 ` [PATCH 5/9] ath9k_hw: remove the old ANI implementation Felix Fietkau
2012-06-15 13:25 ` [PATCH 6/9] ath9k_hw: clean up defines and variables from the ANI implementation split Felix Fietkau
2012-06-15 13:25 ` [PATCH 7/9] ath9k: remove MIB interrupt support Felix Fietkau
2012-06-15 13:25 ` [PATCH 8/9] ath9k_hw: fix setting lower noise immunity values Felix Fietkau
2012-06-15 13:25 ` [PATCH 9/9] ath9k_hw: clean up ANI OFDM trigger handling Felix Fietkau
2012-06-15 18:05 ` [PATCH 8/9] ath9k_hw: fix setting lower noise immunity values Rajkumar Manoharan
2012-06-15 17:58 ` [PATCH 5/9] ath9k_hw: remove the old ANI implementation Rajkumar Manoharan
2012-06-15 21:09 ` Felix Fietkau [this message]
2012-06-17 1:06 ` Sujith Manoharan
2012-06-17 14:36 ` Felix Fietkau
2012-06-18 8:36 ` Sujith Manoharan
2012-06-18 10:12 ` Sujith Manoharan
2012-06-15 17:49 ` [PATCH 4/9] ath9k_hw: clean up / fix ANI mode checks related to beacon RSSI Rajkumar Manoharan
2012-06-15 21:05 ` Felix Fietkau
2012-06-15 17:38 ` [PATCH 2/9] ath9k_hw: fix OFDM weak signal detection handling Rajkumar Manoharan
2012-06-15 21:05 ` Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FDBA47B.7070709@openwrt.org \
--to=nbd@openwrt.org \
--cc=c_manoha@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=rmanohar@qca.qualcomm.com \
--cc=rodrigue@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).