Re: [PATCH 05/10] ath9k: advertise supported WoW flags to upper layer

[Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>]

Hi Julian,

>
> On Wed, Jun 20, 2012 at 1:47 AM, Mohammed Shafi Shajakhan
> <mohammed@qca.qualcomm.com>  wrote:
>> From: Mohammed Shafi Shajakhan<mohammed@qca.qualcomm.com>
>>
>> currently the code supports WoW triggers due to
>> *magic packet
>> *user defined patterns
>> *deauth and disassoc patterns
>> *disconnect - beacon miss, last beacon received timeout,
>> no ack for keeep alive frames.
>>
>> we need to support other WoW offload features in the
>> near future. also a minor cleanup.
>>
>> Cc: Senthil Balasubramanian<senthilb@qca.qualcomm.com>
>> Cc: Rajkumar Manoharan<rmanohar@qca.qualcomm.com>
>> Cc: vadivel@qca.qualcomm.com
>> Tested-by: Mohammed Shafi Shajakhan<mohammed@qca.qualcomm.com>
>> Signed-off-by: Luis R. Rodriguez<mcgrof@qca.qualcomm.com>
>> Signed-off-by: Mohammed Shafi Shajakhan<mohammed@qca.qualcomm.com>
>> ---
>>   drivers/net/wireless/ath/ath9k/init.c |   20 ++++++++++++++++++--
>>   1 files changed, 18 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath/ath9k/init.c
>> index 9dfce1a..d08824f 100644
>> --- a/drivers/net/wireless/ath/ath9k/init.c
>> +++ b/drivers/net/wireless/ath/ath9k/init.c
>> @@ -688,8 +688,8 @@ void ath9k_set_hw_capab(struct ath_softc *sc, struct ieee80211_hw *hw)
>>                 IEEE80211_HW_SPECTRUM_MGMT |
>>                 IEEE80211_HW_REPORTS_TX_ACK_STATUS;
>>
>> -       if (sc->sc_ah->caps.hw_caps&  ATH9K_HW_CAP_HT)
>> -                hw->flags |= IEEE80211_HW_AMPDU_AGGREGATION;
>> +       if (ah->caps.hw_caps&  ATH9K_HW_CAP_HT)
>> +               hw->flags |= IEEE80211_HW_AMPDU_AGGREGATION;
>
> This doesn't look like it belongs with the rest of the patch.
>

its a minor cleanup, but would be best to do it separately. there is 
also another place i did this thing, thanks i will address in v2.

-- 
thanks,
shafi