[PATCH] wlcore: drop INET dependency

[PATCH] wlcore: drop INET dependency

[Randy Dunlap]

From: Randy Dunlap <rdunlap@xenotime.net>

Mainline build reports:

warning: (WL12XX) selects WLCORE which has unmet direct dependencies (NETDEVICES && WLAN && WL_TI && GENERIC_HARDIRQS && MAC80211 && INET)

The INET dependency was added in commit
3c6af5b54fe74b6e56efadc22927e4055d00e9fc:
    wl1271_main.c:(.text+0x271052): undefined reference to `unregister_inetaddr_
notifier'
    wl1271_main.c:(.text+0x2714d7): undefined reference to `register_inetaddr_no
tifier'
    
    Driver is doing some filtering based on IP addresses...

but this driver no longer has that code and it builds fine even when
CONFIG_INET is not enabled, so drop that dependency and eliminate the
kconfig warning message.

Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
Cc: Luciano Coelho <luciano.coelho@nokia.com>
Cc: John W. Linville <linville@tuxdriver.com>
---
 drivers/net/wireless/ti/wlcore/Kconfig |    1 -
 1 file changed, 1 deletion(-)

--- lnx-35-rc3.orig/drivers/net/wireless/ti/wlcore/Kconfig
+++ lnx-35-rc3/drivers/net/wireless/ti/wlcore/Kconfig
@@ -1,7 +1,6 @@
 config WLCORE
 	tristate "TI wlcore support"
 	depends on WL_TI && GENERIC_HARDIRQS && MAC80211
-	depends on INET
 	select FW_LOADER
 	---help---
 	  This module contains the main code for TI WLAN chips.  It abstracts

Re: [PATCH] wlcore: drop INET dependency

[Luciano Coelho]

(updated to my new email address).

On Sun, 2012-06-24 at 19:17 -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@xenotime.net>
> 
> Mainline build reports:
> 
> warning: (WL12XX) selects WLCORE which has unmet direct dependencies (NETDEVICES && WLAN && WL_TI && GENERIC_HARDIRQS && MAC80211 && INET)
> 
> The INET dependency was added in commit
> 3c6af5b54fe74b6e56efadc22927e4055d00e9fc:
>     wl1271_main.c:(.text+0x271052): undefined reference to `unregister_inetaddr_
> notifier'
>     wl1271_main.c:(.text+0x2714d7): undefined reference to `register_inetaddr_no
> tifier'
>     
>     Driver is doing some filtering based on IP addresses...
> 
> but this driver no longer has that code and it builds fine even when
> CONFIG_INET is not enabled, so drop that dependency and eliminate the
> kconfig warning message.
> 
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> Cc: Luciano Coelho <luciano.coelho@nokia.com>
> Cc: John W. Linville <linville@tuxdriver.com>
> ---

Acked-by: Luciano Coelho <coelho@ti.com>

Thanks, Randy!

This one goes quite far back, the dependency in the code was removed in
commit eb887d (wl1271: Use the ARP configuration function from
mac80211), 2 years ago.

I think this should be applied to 3.5 and maybe even to stable (is this
kind of warning important enough to deserve going to stable releases?)

John, can you take this directly into wireless.git?

--
Cheers,
Luca.