From: "Arend van Spriel" <arend@broadcom.com>
To: "Seth Forshee" <seth.forshee@canonical.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
"Linux Wireless List" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] brcmsmac: fix NULL pointer crash in brcms_c_regd_init()
Date: Tue, 26 Jun 2012 11:46:33 +0200 [thread overview]
Message-ID: <4FE984F9.2060502@broadcom.com> (raw)
In-Reply-To: <20120625165345.GB4495@thinkpad-t410>
On 06/25/2012 06:53 PM, Seth Forshee wrote:
> Yeah, I definitely messed that up.
I have my off days as well. We are still human, right ;-)
> This looks fine, but it strikes me that it might simplify things a bit
> to change the loop to iterate over over wlc->pub->_nbands instead. The
> difference is pretty minor though, and since John has already applied
> this patch there's probably no reason to change it.
I considered that but the iterator is used as index in the wiphy.band[]
array further in the loop. So that would require a bit more rework of
the loop (although the internal band index and the one from cfg80211 match).
Gr. AvS
next prev parent reply other threads:[~2012-06-26 9:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-21 13:49 [PATCH] brcmsmac: fix NULL pointer crash in brcms_c_regd_init() Arend van Spriel
2012-06-25 16:53 ` Seth Forshee
2012-06-26 9:46 ` Arend van Spriel [this message]
2012-06-26 19:38 ` Seth Forshee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE984F9.2060502@broadcom.com \
--to=arend@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=seth.forshee@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).