From: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: Felix Fietkau <nbd@openwrt.org>, <linux-wireless@vger.kernel.org>,
Rodriguez Luis <rodrigue@qca.qualcomm.com>,
<ath9k-devel@lists.ath9k.org>,
Rajkumar Manoharan <rmanohar@qca.qualcomm.com>,
Bala Shanmugam <bkamatch@qca.qualcomm.com>,
Senthil Balasubramanian <senthilb@qca.qualcomm.com>
Subject: Re: [PATCH 2/2] ath9k: Fix signedness in a MCI debug message
Date: Wed, 27 Jun 2012 20:44:05 +0530 [thread overview]
Message-ID: <4FEB233D.4070604@qca.qualcomm.com> (raw)
In-Reply-To: <4FEB201D.1020009@qca.qualcomm.com>
On Wednesday 27 June 2012 08:30 PM, Mohammed Shafi Shajakhan wrote:
> Hi Felix,
>
> On Wednesday 27 June 2012 08:18 PM, Felix Fietkau wrote:
>> On 2012-06-27 4:30 PM, Mohammed Shafi Shajakhan wrote:
>>> From: Mohammed Shafi Shajakhan<mohammed@qca.qualcomm.com>
>>>
>>> seems i got a message like this
>>> ath: phy0: BT_Status_Update: is_link=0, linkId=2,
>>> state=1, SEQ=-2085766476 initially.
>>>
>>> Signed-off-by: Mohammed Shafi Shajakhan<mohammed@qca.qualcomm.com>
>>> ---
>>> drivers/net/wireless/ath/ath9k/mci.c | 2 +-
>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/drivers/net/wireless/ath/ath9k/mci.c
>>> b/drivers/net/wireless/ath/ath9k/mci.c
>>> index c40e568..64cc782 100644
>>> --- a/drivers/net/wireless/ath/ath9k/mci.c
>>> +++ b/drivers/net/wireless/ath/ath9k/mci.c
>>> @@ -348,7 +348,7 @@ static void ath_mci_msg(struct ath_softc *sc, u8
>>> opcode, u8 *rx_payload)
>>>
>>> seq_num = *((u32 *)(rx_payload + 12));
>>> ath_dbg(common, MCI,
>>> - "BT_Status_Update: is_link=%d, linkId=%d, state=%d, SEQ=%d\n",
>>> + "BT_Status_Update: is_link=%d, linkId=%d, state=%d, SEQ=%u\n",
>>> profile_status.is_link, profile_status.conn_handle,
>>> profile_status.is_critical, seq_num);
>> What about endian here? Also, wouldn't it be better to have a struct for
>> the rx payload data with proper endian annotation instead of using the
>> weird way of dereferencing the rx_payload pointer?
>>
>
> ok, we shall fix it soon.
>
>
Hi John, please pick this patch, we shall address Felix's suggestion in
a separate patch, i think it needs a bit of rework.
--
thanks,
shafi
prev parent reply other threads:[~2012-06-27 15:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-27 14:30 [PATCH 1/2] ath9k_hw: make use of the wrapper to check for MCI init Mohammed Shafi Shajakhan
2012-06-27 14:30 ` [PATCH 2/2] ath9k: Fix signedness in a MCI debug message Mohammed Shafi Shajakhan
2012-06-27 14:48 ` Felix Fietkau
2012-06-27 15:00 ` Mohammed Shafi Shajakhan
2012-06-27 15:14 ` Mohammed Shafi Shajakhan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FEB233D.4070604@qca.qualcomm.com \
--to=mohammed@qca.qualcomm.com \
--cc=ath9k-devel@lists.ath9k.org \
--cc=bkamatch@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=nbd@openwrt.org \
--cc=rmanohar@qca.qualcomm.com \
--cc=rodrigue@qca.qualcomm.com \
--cc=senthilb@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).