From: Michal Kazior <michal.kazior@tieto.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [RFC v3] initial channel context implementation
Date: Thu, 28 Jun 2012 09:01:47 +0200 [thread overview]
Message-ID: <4FEC015B.4020603@tieto.com> (raw)
In-Reply-To: <1340805730.11012.33.camel@jlt3.sipsolutions.net>
Johannes Berg wrote:
> On Wed, 2012-06-27 at 14:43 +0200, Michal Kazior wrote:
>>> That was intended for AP mode, I'm not sure it's good for station mode,
>>> in station mode we need to have current_bss->channel updated as well in
>>> that case.
>>>
>>>> This would probably require some more
>>>> additional changes too (maybe with regard to channel tracking too).
>>>>
>>>> Worst-case we disconnect other interfaces. We might be able to create a
>>>> new channel context (provided num_different_channels hasn't been reached
>>>> yet) or reuse an existing channel context (provided CSA happens to
>>>> target a channel we have a channel context for already).
>>>
>>> Yeah ... we need to think about it more. I thought we could put it off a
>>> bit longer, but I guess with the channel tracking we already need it?
>>
>> Hmm.. Yeah we need to now, sort of. FullMAC drivers could suffer, but we
>> could drop connections upon CSA in mac80211 for the time being.
>>
>> cfg80211 could provide:
>> * cfg80211_sta_can_switch_chan
>> * cfg80211_sta_ch_switch_notify
>>
>> mac80211 could then be able to know whether num_different_channels has
>> been reached (cfg80211_sta_can_switch_chan) and eventually notify upon
>> channel switch (cfg80211_sta_ch_switch_notify).
>>
>> Channel switch would happen if either:
>> * cfg80211_sta_can_switch_chan is true
>> * channel context for target CSA channel already exists
>>
>> I'm just unsure about the current_bss thing - whether we should e.g.
>> initiate a scan to update it, or can we shamelessly update the channel
>> in the structure directly?
>
> Today mac80211 just updates it, yeah.
Should I send the ,,respect channels in iface combinations'' as a
[PATCH] now, or should the CSA issue (in cfg80211) be addressed first?
--
Pozdrawiam / Best regards, Michal Kazior.
next prev parent reply other threads:[~2012-06-28 7:01 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-26 12:37 [RFC v3] initial channel context implementation Michal Kazior
2012-06-26 12:37 ` [RFC v3 1/7] mac80211: introduce channel context skeleton code Michal Kazior
2012-06-26 12:37 ` [RFC v3 2/7] mac80211: introduce new ieee80211_ops Michal Kazior
2012-06-26 12:37 ` [RFC v3 3/7] mac80211: add drv_* wrappers for channel contexts Michal Kazior
2012-06-26 12:37 ` [RFC v3 4/7] mac80211: add chanctx tracing Michal Kazior
2012-06-26 12:37 ` [RFC v3 5/7] mac80211: use channel context notifications Michal Kazior
2012-06-26 13:35 ` Johannes Berg
2012-06-26 14:01 ` Michal Kazior
2012-06-26 15:34 ` Johannes Berg
2012-06-26 12:37 ` [RFC v3 6/7] mac80211: refactor set_channel_type Michal Kazior
2012-06-26 14:04 ` Eliad Peller
2012-06-26 12:37 ` [RFC v3 7/7] mac80211: reuse channels for channel contexts Michal Kazior
2012-06-26 13:41 ` Johannes Berg
2012-06-26 13:55 ` Michal Kazior
2012-06-26 15:34 ` Johannes Berg
2012-06-26 13:43 ` [RFC v3] initial channel context implementation Johannes Berg
2012-06-27 7:30 ` Michal Kazior
2012-06-27 8:10 ` Johannes Berg
2012-06-27 10:13 ` Michal Kazior
2012-06-27 11:10 ` Johannes Berg
2012-06-27 12:43 ` Michal Kazior
2012-06-27 14:02 ` Johannes Berg
2012-06-28 6:04 ` Michal Kazior
2012-06-28 7:31 ` Johannes Berg
2012-06-28 7:54 ` Michal Kazior
2012-06-28 8:13 ` Johannes Berg
2012-06-28 9:20 ` Michal Kazior
2012-06-28 9:27 ` Johannes Berg
2012-06-28 9:47 ` Michal Kazior
2012-06-28 7:01 ` Michal Kazior [this message]
2012-06-28 8:15 ` Johannes Berg
2012-06-28 8:54 ` Michal Kazior
2012-06-28 9:27 ` Johannes Berg
2012-07-25 10:22 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FEC015B.4020603@tieto.com \
--to=michal.kazior@tieto.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).