Re: [PATCH] wlcore: implement .flush callback

["Arend van Spriel" <arend@broadcom.com>]

On 06/28/2012 01:31 PM, Arik Nemtsov wrote:
> On Thu, Jun 28, 2012 at 2:25 PM, Eliad Peller <eliad@wizery.com> wrote:
>> On Thu, Jun 28, 2012 at 2:07 PM, Arend van Spriel <arend@broadcom.com> wrote:
>>> On 06/27/2012 06:09 PM, Luciano Coelho wrote:
>>>> From: Eliad Peller <eliad@wizery.com>
>>>>
>>>> implement the .flush() callback by simply calling wl1271_tx_flush().
>>>>
>>>> Signed-off-by: Eliad Peller <eliad@wizery.com>
>>>> Signed-off-by: Luciano Coelho <coelho@ti.com>
>>>> ---
>>>>  drivers/net/wireless/ti/wlcore/main.c |    8 ++++++++
>>>>  1 file changed, 8 insertions(+)
>>>>
>>>> diff --git a/drivers/net/wireless/ti/wlcore/main.c b/drivers/net/wireless/ti/wlcore/main.c
>>>> +static void wlcore_op_flush(struct ieee80211_hw *hw, bool drop)
>>>> +{
>>>> +     struct wl1271 *wl = hw->priv;
>>>> +
>>>> +     wl1271_tx_flush(wl);
>>>> +}
>>>> +
>>>
>>> So not taking the drop flag into account? Any plan to change that?
>>>
>> yeah, good point...
>> i guess we'll want to add support for the drop flag as well.
>>
>> Luca - you can either drop this patch, or apply it for now and i'll
>> send another patch later on.
> 
> Currently we drop all the packets if we can't flush them within a
> reasonable time. We always do this right now. I think that's good
> enough?
> 

Hard to say as I am working mostly on your side of this API. However,
the drop flag is part of the API so there is probably a reason for
having it. Johannes?

Gr. AvS