From: Hauke Mehrtens <hauke@hauke-m.de>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
Joe Perches <joe@perches.com>
Subject: Re: [PATCH V2] bcma: use custom printing functions
Date: Sat, 30 Jun 2012 01:51:44 +0200 [thread overview]
Message-ID: <4FEE3F90.7020409@hauke-m.de> (raw)
In-Reply-To: <1340971809-23703-1-git-send-email-zajec5@gmail.com>
On 06/29/2012 02:10 PM, Rafał Miłecki wrote:
> Having bus number printed makes it much easier to anaylze logs on
> systems with more buses. For example Netgear WNDR4500 has 3 AMBA buses
> in total, which makes standard log really messy.
>
> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
> ---
> V2: don't create "bus" variable when it's not really helpful
> don't brak strings
>
> John: this applies on top of 5 patches accepted in the
> [PATCH 0/8] bcma misc updates
> patchset.
>
> So:
> wireless-testing +
> bcma: extend workaround for bcm4331
> bcma: add constants for chip ids
> bcma: add PCI ID for BCM43224
> bcma: complete workaround for BCMA43224 and BCM4313
> bcma: add bcma_pmu_spuravoid_pllupdate()
>
> And then:
> bcma: use custom printing functions
> applies cleanly :)
After applying your patch I still found some pr_ statements in the code,
just use "grep pr_ drivers/bcma/ -r", is this intended?
I just send a new version of my patches for bcma, they are now removing
some functions form driver_chipcommon_pmu.c so your patch will not apply
on them any more.
Hauke
next prev parent reply other threads:[~2012-06-29 23:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-29 12:10 [PATCH V2] bcma: use custom printing functions Rafał Miłecki
2012-06-29 23:51 ` Hauke Mehrtens [this message]
2012-06-30 9:24 ` Rafał Miłecki
2012-06-30 9:40 ` Hauke Mehrtens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FEE3F90.7020409@hauke-m.de \
--to=hauke@hauke-m.de \
--cc=joe@perches.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).