* [RFC] ath9k: Fix MCI cleanup
@ 2012-07-03 15:17 Mohammed Shafi Shajakhan
2012-07-03 15:26 ` Mohammed Shafi Shajakhan
0 siblings, 1 reply; 2+ messages in thread
From: Mohammed Shafi Shajakhan @ 2012-07-03 15:17 UTC (permalink / raw)
To: John W. Linville
Cc: linux-wireless, Rodriguez Luis, ath9k-devel, Rajkumar Manoharan,
Bala Shanmugam, Senthil Balasubramanian, Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
We are doing MCI cleanup eventhough BTCOEX is not enabled
via module parameter. This means we do ath_mci_cleanup
though we skipped calling ath_mci_setup. Yet it does not
causes any issues now as we free the DMA buffer allocated
only when it is allocated during ath_mci_setup.
Signed-off-by: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
---
drivers/net/wireless/ath/ath9k/gpio.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/gpio.c b/drivers/net/wireless/ath/ath9k/gpio.c
index 5eac4d1..43557c2 100644
--- a/drivers/net/wireless/ath/ath9k/gpio.c
+++ b/drivers/net/wireless/ath/ath9k/gpio.c
@@ -387,11 +387,13 @@ void ath9k_stop_btcoex(struct ath_softc *sc)
void ath9k_deinit_btcoex(struct ath_softc *sc)
{
+ struct ath_hw *ah = sc->sc_ah;
+
if ((sc->btcoex.no_stomp_timer) &&
ath9k_hw_get_btcoex_scheme(sc->sc_ah) == ATH_BTCOEX_CFG_3WIRE)
ath_gen_timer_free(sc->sc_ah, sc->btcoex.no_stomp_timer);
- if (AR_SREV_9462(sc->sc_ah))
+ if (ath9k_hw_mci_is_enabled(ah))
ath_mci_cleanup(sc);
}
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [RFC] ath9k: Fix MCI cleanup
2012-07-03 15:17 [RFC] ath9k: Fix MCI cleanup Mohammed Shafi Shajakhan
@ 2012-07-03 15:26 ` Mohammed Shafi Shajakhan
0 siblings, 0 replies; 2+ messages in thread
From: Mohammed Shafi Shajakhan @ 2012-07-03 15:26 UTC (permalink / raw)
To: linux-wireless
Cc: Mohammed Shafi Shajakhan, John W. Linville, Rodriguez Luis,
ath9k-devel, Rajkumar Manoharan, Bala Shanmugam,
Senthil Balasubramanian
On Tuesday 03 July 2012 08:47 PM, Mohammed Shafi Shajakhan wrote:
> From: Mohammed Shafi Shajakhan<mohammed@qca.qualcomm.com>
>
> We are doing MCI cleanup eventhough BTCOEX is not enabled
> via module parameter. This means we do ath_mci_cleanup
> though we skipped calling ath_mci_setup. Yet it does not
> causes any issues now as we free the DMA buffer allocated
> only when it is allocated during ath_mci_setup.
>
> Signed-off-by: Mohammed Shafi Shajakhan<mohammed@qca.qualcomm.com>
> ---
> drivers/net/wireless/ath/ath9k/gpio.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath9k/gpio.c b/drivers/net/wireless/ath/ath9k/gpio.c
> index 5eac4d1..43557c2 100644
> --- a/drivers/net/wireless/ath/ath9k/gpio.c
> +++ b/drivers/net/wireless/ath/ath9k/gpio.c
> @@ -387,11 +387,13 @@ void ath9k_stop_btcoex(struct ath_softc *sc)
>
> void ath9k_deinit_btcoex(struct ath_softc *sc)
> {
> + struct ath_hw *ah = sc->sc_ah;
> +
> if ((sc->btcoex.no_stomp_timer)&&
> ath9k_hw_get_btcoex_scheme(sc->sc_ah) == ATH_BTCOEX_CFG_3WIRE)
> ath_gen_timer_free(sc->sc_ah, sc->btcoex.no_stomp_timer);
>
> - if (AR_SREV_9462(sc->sc_ah))
> + if (ath9k_hw_mci_is_enabled(ah))
> ath_mci_cleanup(sc);
> }
>
also we unnecessarily call ar9003_mci_cleanup.
--
thanks,
shafi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-07-03 15:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-03 15:17 [RFC] ath9k: Fix MCI cleanup Mohammed Shafi Shajakhan
2012-07-03 15:26 ` Mohammed Shafi Shajakhan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).