From: "Arend van Spriel" <arend@broadcom.com>
To: "Xose Vazquez Perez" <xose.vazquez@gmail.com>
Cc: "Luis R. Rodriguez" <mcgrof@frijolero.org>,
linville@tuxdriver.com, wireless-regdb@lists.infradead.org,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] wireless-regdb: Update regulatory rules for ES (Spain) on 5GHz and 2.4GHz
Date: Wed, 4 Jul 2012 08:01:21 +0200 [thread overview]
Message-ID: <4FF3DC31.2030004@broadcom.com> (raw)
In-Reply-To: <4FF396DD.7060408@gmail.com>
On 07/04/2012 03:05 AM, Xose Vazquez Perez wrote:
> On 07/04/2012 02:49 AM, Luis R. Rodriguez wrote:
>> On Tue, Jul 3, 2012 at 5:41 PM, Xose Vazquez Perez
>> <xose.vazquez@gmail.com> wrote:
>
>>> country ES: DFS-ETSI
>>> - (2402 - 2482 @ 40), (N/A, 20)
>>> - (5170 - 5250 @ 40), (N/A, 20)
>>> - (5250 - 5330 @ 40), (N/A, 20), DFS
>>> - (5490 - 5710 @ 40), (N/A, 27), DFS
>>> + (2400 - 2483.5 @ 40), (N/A, 100 mW)
>>> + (5150 - 5250 @ 40), (N/A, 100 mW), NO-OUTDOOR
>>> + (5250 - 5350 @ 40), (N/A, 100 mW), NO-OUTDOOR, DFS
>>> + (5470 - 5725 @ 40), (N/A, 500 mW), DFS
>
>> You are changing from dBm to mW directly... please do the unit change
>> in one patch and *then* the actual change. This would make it easier
>> to review....
>
> I did copy & paste from DE to ES. These are basic CEPT rules.
>
> 10 log(100) = 20
> 10 log(500) ~ 27
>
> Anyway tomorrow, I will send a new patch.
Just a general remark not specific to this patch. The commit message
often contains a source reference. I think it would be useful to have
this reference in the database a well so people validating it do not
need to do the digging using 'git blame'. Does that make sense?
Gr. AvS
next prev parent reply other threads:[~2012-07-04 6:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-04 0:41 [PATCH v2] wireless-regdb: Update regulatory rules for ES (Spain) on 5GHz and 2.4GHz Xose Vazquez Perez
2012-07-04 0:49 ` Luis R. Rodriguez
2012-07-04 1:05 ` Xose Vazquez Perez
2012-07-04 6:01 ` Arend van Spriel [this message]
2012-07-09 13:14 ` Kalle Valo
2012-08-13 14:01 ` Arend van Spriel
2012-08-13 14:04 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF3DC31.2030004@broadcom.com \
--to=arend@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mcgrof@frijolero.org \
--cc=wireless-regdb@lists.infradead.org \
--cc=xose.vazquez@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).