linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH] mac80211: use full power if off-channel
Date: Sun, 08 Jul 2012 07:34:40 -0700	[thread overview]
Message-ID: <4FF99A80.9040700@candelatech.com> (raw)
In-Reply-To: <1341740130-6199-1-git-send-email-johannes@sipsolutions.net>

On 07/08/2012 02:35 AM, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> Instead of using full power when scanning, use
> full power when off-channel. This is different
> since off-channel can be remain-on-channel.

What if we are scanning on our current channel?  Shouldn't
it be full-power then as well?

Thanks,
Ben

>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
>   net/mac80211/main.c |    4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/net/mac80211/main.c b/net/mac80211/main.c
> index e706f9e..35c4b1d 100644
> --- a/net/mac80211/main.c
> +++ b/net/mac80211/main.c
> @@ -148,9 +148,7 @@ int ieee80211_hw_config(struct ieee80211_local *local, u32 changed)
>   		changed |= IEEE80211_CONF_CHANGE_SMPS;
>   	}
>
> -	if (test_bit(SCAN_SW_SCANNING, &local->scanning) ||
> -	    test_bit(SCAN_ONCHANNEL_SCANNING, &local->scanning) ||
> -	    test_bit(SCAN_HW_SCANNING, &local->scanning))
> +	if (local->hw.conf.flags & IEEE80211_CONF_OFFCHANNEL)
>   		power = chan->max_power;
>   	else
>   		power = local->power_constr_level ?
>


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com



  reply	other threads:[~2012-07-08 14:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-08  9:35 [PATCH] mac80211: use full power if off-channel Johannes Berg
2012-07-08 14:34 ` Ben Greear [this message]
2012-07-09  8:29   ` Johannes Berg
2012-07-09 14:50     ` Ben Greear
2012-07-09 14:55       ` Johannes Berg
2012-07-09 16:02         ` Ben Greear

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FF99A80.9040700@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=johannes.berg@intel.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).