From: "Arend van Spriel" <arend@broadcom.com>
To: "Thomas Huehn" <thomas@net.t-labs.tu-berlin.de>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
nbd@openwrt.org, brcm80211-dev-list@broadcom.com,
pieterpg@broadcom.com, gregkh@suse.de, frankyl@broadcom.com,
rvossen@broadcom.com, brudley@broadcom.com
Subject: Re: [PATCH v3] brcmsmac: restructure info->control.sta handling as it is goning to be removed soon.
Date: Tue, 10 Jul 2012 13:00:49 +0200 [thread overview]
Message-ID: <4FFC0B61.7080506@broadcom.com> (raw)
In-Reply-To: <1341914697-59039-1-git-send-email-thomas@net.t-labs.tu-berlin.de>
On 07/10/2012 12:04 PM, Thomas Huehn wrote:
> brcmsmac uses info->control.sta while doing ampdu aggregation. This patch
> changes the usage of the structure info->control.sta, as it is going to be
> removed soon from struct ieee80211_tx_info. This patch is a pre-requisit in
> order to add transmission power control (TPC) to the mac80211 subsystem.
>
> Suggested-by: Felix Fietkau <nbd@openwrt.org>
> Signed-off-by: Thomas Huehn <thomas@net.t-labs.tu-berlin.de>
> ---
> sta pointer is not used in brcms_c_sendampdu(), sta removed. thx to A.v.Spriel
> ---
> drivers/net/wireless/brcm80211/brcmsmac/ampdu.c | 10 ++++------
> drivers/net/wireless/brcm80211/brcmsmac/mac80211_if.c | 2 ++
> drivers/net/wireless/brcm80211/brcmsmac/main.c | 2 +-
> 3 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c b/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c
> index 01b190a..77c5f57 100644
> --- a/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c
> +++ b/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c
> @@ -665,8 +665,6 @@ brcms_c_sendampdu(struct ampdu_info *ampdu, struct brcms_txq_info *qi,
> u8 plcp0, plcp3, is40, sgi;
> struct ieee80211_sta *sta;
>
> - sta = tx_info->control.sta;
> -
> if (rr) {
Now it probably results in a compiler warning. Declaration can go as well.
Gr. AvS
prev parent reply other threads:[~2012-07-10 11:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-10 10:04 [PATCH v3] brcmsmac: restructure info->control.sta handling as it is goning to be removed soon Thomas Huehn
2012-07-10 11:00 ` Arend van Spriel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFC0B61.7080506@broadcom.com \
--to=arend@broadcom.com \
--cc=brcm80211-dev-list@broadcom.com \
--cc=brudley@broadcom.com \
--cc=frankyl@broadcom.com \
--cc=gregkh@suse.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=nbd@openwrt.org \
--cc=pieterpg@broadcom.com \
--cc=rvossen@broadcom.com \
--cc=thomas@net.t-labs.tu-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).