From: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: <linux-wireless@vger.kernel.org>
Subject: Re: [RFC] nl80211: Avoid checking for empty WoWLAN triggers
Date: Tue, 10 Jul 2012 16:46:50 +0530 [thread overview]
Message-ID: <4FFC0F22.6040906@qca.qualcomm.com> (raw)
In-Reply-To: <1341918365.4475.9.camel@jlt3.sipsolutions.net>
Hi Johannes,
On Tuesday 10 July 2012 04:36 PM, Johannes Berg wrote:
> On Tue, 2012-07-10 at 15:37 +0530, Mohammed Shafi Shajakhan wrote:
>> From: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
>>
>> Previously we would check in nl80211 with an empty
>> cfg80211_wowlan structure to check for 'iw phy phyX wowlan enable'
>> with empty arguments (or) no triggers and disable WoWLAN.
>
> No ... that's not how it works. If you enable WoWLAN without any
> triggers, then that's what you get: the connection is kept alive but
> there are no wakeup sources. If you don't specify the triggers at all
> then it's disabled.
>
If we want to do disable WoWLAN we can use the command 'iw phy phyX
wowlan disable' command. Its true that we would 'Keep Alive'
the connection, but we would disable the wake up capability via
'set_wakeup' callback, something similar to wowlan disable command.
Please let me know if i am missing something (or) the advantage having
the connection Keep alive with wowlan enable without triggers.
thank you!
--
thanks,
shafi
next prev parent reply other threads:[~2012-07-10 11:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-10 10:07 [RFC] nl80211: Avoid checking for empty WoWLAN triggers Mohammed Shafi Shajakhan
2012-07-10 11:06 ` Johannes Berg
2012-07-10 11:16 ` Mohammed Shafi Shajakhan [this message]
2012-07-10 11:20 ` Johannes Berg
2012-07-10 11:36 ` Mohammed Shafi Shajakhan
2012-07-11 5:33 ` Mohammed Shafi Shajakhan
2012-07-12 14:24 ` Johannes Berg
2012-07-12 15:14 ` Mohammed Shafi Shajakhan
2012-07-12 15:17 ` Johannes Berg
2012-07-12 15:33 ` Mohammed Shafi Shajakhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFC0F22.6040906@qca.qualcomm.com \
--to=mohammed@qca.qualcomm.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).