From: Hauke Mehrtens <hauke@hauke-m.de>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC][PATCH] bcma: add trivial GBIT MAC COMMON driver
Date: Wed, 11 Jul 2012 00:19:43 +0200 [thread overview]
Message-ID: <4FFCAA7F.502@hauke-m.de> (raw)
In-Reply-To: <CACna6rzx8Jt215zJ3WD49XypBShC8yxfQfOwnqgFc0xYsx_6JQ@mail.gmail.com>
On 07/10/2012 11:56 PM, Rafał Miłecki wrote:
> 2012/7/10 Rafał Miłecki <zajec5@gmail.com>:
>> 2012/7/10 Hauke Mehrtens <hauke@hauke-m.de>:
>>> On 07/08/2012 02:51 PM, Rafał Miłecki wrote:
>>>> GMAC COMMON core is present on BCM4706 and is used for example to access
>>>> board PHYs (PHYs can not be accessed directly using GBIT MAC core).
>>>
>>> I think this is the cleanest way of doing this. I thought about handling
>>> this in the Ethernet driver, but as we need locking, an extra driver
>>> would be needed, just for this stupid locking.
>>>
>>> You should not register an external device for this core in
>>> bcma_register_cores().
>>
>> I've just noticed my BCM4706 doesn't have GBIT MAC CMN... but AFAIK
>> BCM4706 GMAC (0x52d) can not operate without GMAC CMN (0x5dc)...
>>
>> Hauke: does it make any sense to you?
>
> OK, I found out that quickly.
>
> First of all, there is some bridge on my bus. bcma_erom_is_bridge
> returns true at some point of scanning.
>
> Secondly I've printed cia for
> if (wrappers[0] + wrappers[1] == 0)
> case:
> [ 2.360000] bcma: bus0: cia 0x43B36701 (0x367)
> [ 2.368000] bcma: bus0: cia 0x43B36601 (0x366)
> [ 2.372000] bcma: bus0: cia 0x43B01A01 (0x01A)
> [ 2.376000] bcma: bus0: cia 0x43B01B01 (0x01B)
> [ 2.380000] bcma: bus0: cia 0x43B01C01 (0x01C)
> [ 2.388000] bcma: bus0: cia 0x43B5DC01 (0x5DC)
> [ 2.392000] bcma: bus0: cia 0x43B5DD01 (0x5DD)
>
Nice, there is the gmac common core. Will you write a patch extending
the scan function to find this core?
Hauke
next prev parent reply other threads:[~2012-07-10 22:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-08 12:51 [RFC][PATCH] bcma: add trivial GBIT MAC COMMON driver Rafał Miłecki
2012-07-09 23:01 ` Hauke Mehrtens
2012-07-10 5:02 ` Rafał Miłecki
2012-07-10 21:43 ` Rafał Miłecki
2012-07-10 21:56 ` Rafał Miłecki
2012-07-10 22:19 ` Hauke Mehrtens [this message]
2012-07-11 4:44 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFCAA7F.502@hauke-m.de \
--to=hauke@hauke-m.de \
--cc=linux-wireless@vger.kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).