Re: [RFC] nl80211: Avoid checking for empty WoWLAN triggers

[Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>]

Hi Johannes,

>>
>> On Tuesday 10 July 2012 04:36 PM, Johannes Berg wrote:
>>> On Tue, 2012-07-10 at 15:37 +0530, Mohammed Shafi Shajakhan wrote:
>>>> From: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
>>>>
>>>> Previously we would check in nl80211 with an empty
>>>> cfg80211_wowlan structure to check for 'iw phy phyX wowlan enable'
>>>> with empty arguments (or) no triggers and disable WoWLAN.
>>>
>>> No ... that's not how it works. If you enable WoWLAN without any
>>> triggers, then that's what you get: the connection is kept alive but
>>> there are no wakeup sources. If you don't specify the triggers at all
>>> then it's disabled.
>>>
>>
>> If we want to do disable WoWLAN we can use the command 'iw phy phyX
>> wowlan disable' command. Its true that we would 'Keep Alive'
>> the connection, but we would disable the wake up capability via
>> 'set_wakeup' callback, something similar to wowlan disable command.
>> Please let me know if i am missing something (or) the advantage having
>> the connection Keep alive with wowlan enable without triggers.
>
> I don't know if there's any advantage. It could be useful for example to
> get a connection up quicker after resume. I just didn't want to preclude
> that use case.
>

sorry i just missed this thing. rdev->wowlan is made 'false' for empty 
wowlan enable triggers, then we would not call drv_suspend/resume 
callback, this would prevent the device from retaining the connection.
I would just check this with ath9k.


-- 
thanks,
shafi