From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=91.218.175.166 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793371907; b=0LrKSviQokU7g0GUqoRoyXpHmLbZqMXixw9uaLbBRifL82RbcwhSDjGfqdmayo4GcHhC Yv8LSTTLqaj9NgnigIC8jG5hIvHinIzaWOx9D7DzGf8fqU3TgYFMabHJ/J7IxB2393T+I T/KSC+hEwOjbRZ4LyJdzLfwzrcCQTvBQjx7SvUc+w7770TFqNOE/vIGQhI80iugfWS99A MzJ9zbqYgv9LNct1+lUxblqpcqnElYbYa99V/jNqd733/j/8cY+YYEjGg9kmNDjfuNZSw VMH6B7HwZXEWe5JEGz2/XiuMJQ5NI8+6a718rAEgyD7KQPpb9HqeSos7PTA73NJVqRw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793371907; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:MIME-Version:Date:Content-Type: Content-Transfer-Encoding:From:Message-ID:TLS-Required:Subject:To:Cc: In-Reply-To:References; bh=2HtbNoPaGhVx1oIleRCrYh9Q+TVpcVTko3WuWXqXEEE=; b=3xFch0xOwd7fP5sQn+Nmqzz1g35INltq+gQsMMSoW7oseLvhYacFC8McLO6TJU80PWmS Dcq/bmHxL8fnOUML5AkRhbodvQmEefoYTutOIWwUDaUP5UF232tgLn1ZIoxVRp9FjIxNk uG8XFTrrEJM7Lq3Sa7wrLdwt2uSxbUQJ3tIL3rMrdwTQAR5z6EwZAGD7vRB0wyO3myzAh e1DLES7uCt5zb0Rf1jwWptwT+PkrKwrHYpFAZI/k4tZ5LTT6XTiZH1Nyu7RpDjW7n/cm/ R2/FqfUAKGty+QfdoggD16RcFNnZqinjS1efd78iQTJ4b2ispY2EKJgNBaaqzpwYlVQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=IG002WtX; arc=none smtp.remote-ip=91.218.175.166 Received: from mta0.migadu.com (out-166.mta0.migadu.com [91.218.175.166]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB25A606A31E for ; Fri, 30 Oct 2026 14:51:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org AB25A606A31E Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=IG002WtX X-Envelope-To: linux-wireless@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=HKmC/zLtQ35zzhpn8XzyD4VRPec5/dy8PDlsxOcGW5A=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1793371903; v=1; x=1793976703; b=IG002WtXR3CahR9dJc7fQkF613xha+VIj85wMJAmnpxDyjG2MBwfsK5A9mA8a554UmeaMeZU +wxyeBs9vTKbHz3jT499XGFHJg2FXGBVvSFVi6293YEE1377/Dy3uLg/jTqDfklJQJjhcyG5HBl QiEy+H4cRqu6FQLtL5nKXflE= X-Envelope-To: linux-wireless@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 0481539a351a8ac5; Fri, 30 Oct 2026 14:51:43 +0000 X-Mizu-Trace-ID: 0481539a351a8ac5 X-Migadu-Flow: FLOW_OUT X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Date: Fri, 30 Oct 2026 14:51:43 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: "Luka Gejak" Message-ID: <4a555879477e2c5b8eb2f2cd430157adef580461@linux.dev> TLS-Required: No Subject: Re: [PATCH] wifi: rtw88: usb: stop RX work before unregistering hardware To: "Zhao Li" , "Ping-Ke Shih" Cc: "neo_jou" , "Sascha Hauer" , "Kalle Valo" , "Hans Ulli Kroll" , "Bitterblue Smith" , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org In-Reply-To: <20261028141904.8707-1-enderaoelyther@gmail.com> References: <20261028141904.8707-1-enderaoelyther@gmail.com> Hi Zhao, Thanks for the fix. One comment below. October 28, 2026 at 3:19 PM, "Zhao Li" wrote: > diff --git a/drivers/net/wireless/realtek/rtw88/usb.c b/drivers/net/wir= eless/realtek/rtw88/usb.c > index 64e1c3420e0a..1d2759eb96bf 100644 > --- a/drivers/net/wireless/realtek/rtw88/usb.c > +++ b/drivers/net/wireless/realtek/rtw88/usb.c > @@ -1370,7 +1370,10 @@ void rtw_usb_disconnect(struct usb_interface *in= tf) > rtwdev =3D hw->priv; > rtwusb =3D rtw_get_usb_priv(rtwdev); > > + /* Stop deferred resubmission before killing the active RX URBs. = */ > + disable_work_sync(&rtwusb->rx_urb_work); As far as I can see, rx_urb_work can't bring an URB back at this point. rtw88 doesn't set soft_unbind, so the USB core disables the endpoints before it calls the driver: usb_unbind_interface() usb_disable_interface() usb_disable_endpoint() ep->enabled =3D 0; driver->disconnect() rtw_usb_disconnect() After that usb_submit_urb() on the RX pipe fails for the rest of the RX teardown, and a failed submit only queues the work again on -ENOMEM. So I think cancel_work_sync() on rx_work alone already closes the race, and the same change would then work for the older stable trees too. Keeping disable_work_sync() doesn't hurt, but then the commit message shouldn't say the work can restart a killed URB. Or did I miss a path where we get here with the endpoints still enabled? Best regards, Luka Gejak