From: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
To: Benoit Masson <benoitm@perenite.com>,
Rameshkumar Sundaram <rameshkumar.sundaram@oss.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, ath12k@lists.infradead.org,
stable@vger.kernel.org, Jeff Johnson <jjohnson@kernel.org>
Subject: Re: [PATCH] wifi: ath12k: assign device id from the WSI index
Date: Mon, 28 Sep 2026 11:07:44 -0700 [thread overview]
Message-ID: <4af0fe72-4b55-47ff-91f3-06221e563231@oss.qualcomm.com> (raw)
In-Reply-To: <20260928154335.85628-1-yahoo@perenite.com>
On 9/28/2026 8:43 AM, Benoit Masson wrote:
> Devices of a hardware group are added to ag->ab[] in PCI probe
> completion order (ab->device_id = ag->num_probed++). The wiphy radio
> array is built from ag->ab[] and the wiphy device is taken from its
> first entry, so the wiphy path and the radio index to band mapping
> change on every boot.
you don't describe why this is is a problem, and hence why it should be
considered for backporting to stable kernels.
>
> Store each ab in ag->ab[] at its wsi_info.index, which is derived from
> the device tree WSI ring. The group order is then deterministic.
> ag->num_probed remains the group device counter. The unassign path is
> unchanged, it already indexes ag->ab[] by ab->device_id.
>
> Verified on TP-Link Archer BE800 (three single-band radios in one
> group): the wiphy path and the radio index to band mapping are
> identical across cold boots.
>
> Fixes: 6f245ea0ec6c ("wifi: ath12k: introduce device group abstraction")
> Cc: stable@vger.kernel.org # 6.14+
> Signed-off-by: Benoit Masson <yahoo@perenite.com>
SOB doesn't match your From address. So you either need to change your SOB,
update your From address in your e-mail agent, or add a From: tag to you patch
so that From == SOB
> ---
> Changes in v2:
> - Set ab->device_id from wsi_info.index in ath12k_core_hw_group_assign()
> instead of reordering pdev_map[] in ath12k_mac_allocate(), as suggested
> by Rameshkumar. mac.c is no longer modified.
your e-mail subject doesn't reflect that this is a v2, and it was threaded
instead of being sent as a separate e-mail thread.
when you send a v3 that addresses the above please make sure to use a properly
versioned subject and send as a separate thread.
Thanks
/jeff
prev parent reply other threads:[~2026-09-28 18:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-27 1:23 [PATCH] wifi: ath12k: order hw group devices by WSI index Benoit Masson
2026-09-28 15:26 ` Rameshkumar Sundaram
2026-09-28 15:43 ` [PATCH] wifi: ath12k: assign device id from the " Benoit Masson
2026-09-28 18:07 ` Jeff Johnson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4af0fe72-4b55-47ff-91f3-06221e563231@oss.qualcomm.com \
--to=jeff.johnson@oss.qualcomm.com \
--cc=ath12k@lists.infradead.org \
--cc=benoitm@perenite.com \
--cc=jjohnson@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rameshkumar.sundaram@oss.qualcomm.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox