Linux wireless drivers development
 help / color / mirror / Atom feed
From: Arend Van Spriel <arend.vanspriel@broadcom.com>
To: Denis Kenzior <denkenz@gmail.com>,
	Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: NL80211_SCAN_FLAG_RANDOM_ADDR ?
Date: Fri, 12 Apr 2019 23:21:27 +0200	[thread overview]
Message-ID: <4af24a86-8c0c-cb8f-b03f-4377fcd31465@broadcom.com> (raw)
In-Reply-To: <241d2caa-6f41-6363-5164-d2ac83463beb@gmail.com>

On 4/12/2019 5:00 PM, Denis Kenzior wrote:
> Or put another way, besides hardware limitations, are there reasons why 
> you would not want to randomize probe request address when connected?

I was hoping to find your answer using 'git blame'. You might already 
have tried that. The wdev->current_bss check was added by the commit below:

commit ad2b26abc157460ca6fac1a53a2bfeade283adfa
Author: Johannes Berg <johannes.berg@intel.com>
Date:   Thu Jun 12 21:39:05 2014 +0200

     cfg80211: allow drivers to support random MAC addresses for scan

     Add the necessary feature flags and a scan flag to support using
     random MAC addresses for scan while unassociated.

     The configuration for this supports an arbitrary MAC address
     value and mask, so that any kind of configuration (e.g. fixed
     OUI or full 46-bit random) can be requested. Full 46-bit random
     is the default when no other configuration is passed.

     Also add a small helper function to use the addr/mask correctly.

     Signed-off-by: Johannes Berg <johannes.berg@intel.com>

Unfortunately it does not answer your question. My memory is lacking 
quite a bit but I think at the time it was not considered useful to have 
random mac address for scan while being associated. Your permanent mac 
address would be flying around anyway.

Regards,
Arend

      reply	other threads:[~2019-04-12 21:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-11 22:30 NL80211_SCAN_FLAG_RANDOM_ADDR ? Denis Kenzior
2019-04-11 23:19 ` Ben Greear
2019-04-11 23:20   ` Ben Greear
2019-04-12  1:26     ` Denis Kenzior
2019-04-12  2:15       ` Ben Greear
2019-04-12  9:26 ` Sergey Matyukevich
2019-04-12 15:00   ` Denis Kenzior
2019-04-12 21:21     ` Arend Van Spriel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4af24a86-8c0c-cb8f-b03f-4377fcd31465@broadcom.com \
    --to=arend.vanspriel@broadcom.com \
    --cc=denkenz@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=sergey.matyukevich.os@quantenna.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox