Re: [PATCH 16/16] carl9170: cmd: downgrade transient register I/O errors to wiphy_dbg

[Christian Lamparter <chunkeey@gmail.com>]

On 3/17/26 12:06 PM, Masi Osmani wrote:
> Register read/write failures during deauth/teardown transitions are
> harmless — mac80211 tries to read survey stats or write slot_time
> while the firmware is in a transitional state.  The command times
> out with -EIO but the adapter recovers and re-authenticates normally.
> 
> Downgrade both "writing reg ... failed" and "reading regs failed"
> from wiphy_err to wiphy_dbg to reduce dmesg noise.  The errors are
> still visible with dynamic debug enabled for investigation.


Sure

Acked-By: Christian Lamparter <chunkeey@gmail.com>

> 
> Signed-off-by: Masi Osmani <mas-i@hotmail.de>
> ---
>   drivers/net/wireless/ath/carl9170/cmd.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/carl9170/cmd.c b/drivers/net/wireless/ath/carl9170/cmd.c
> --- a/drivers/net/wireless/ath/carl9170/cmd.c
> +++ b/drivers/net/wireless/ath/carl9170/cmd.c
> @@ -52,7 +52,7 @@
>   				(u8 *) buf, 0, NULL);
>   	if (err) {
>   		if (net_ratelimit()) {
> -			wiphy_err(ar->hw->wiphy, "writing reg %#x "
> +			wiphy_dbg(ar->hw->wiphy, "writing reg %#x "
>   				"(val %#x) failed (%d)\n", reg, val, err);
>   		}
>   	}
> @@ -78,7 +78,7 @@
>   				4 * nregs, (u8 *)res);
>   	if (err) {
>   		if (net_ratelimit()) {
> -			wiphy_err(ar->hw->wiphy, "reading regs failed (%d)\n",
> +			wiphy_dbg(ar->hw->wiphy, "reading regs failed (%d)\n",
>   				  err);
>   		}
>   		return err;