From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80094CA9EAF for ; Wed, 30 Oct 2019 09:03:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5627D2083E for ; Wed, 30 Oct 2019 09:03:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726091AbfJ3JDv (ORCPT ); Wed, 30 Oct 2019 05:03:51 -0400 Received: from s3.sipsolutions.net ([144.76.43.62]:56154 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726213AbfJ3JDv (ORCPT ); Wed, 30 Oct 2019 05:03:51 -0400 Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.92.2) (envelope-from ) id 1iPjtN-0005Hy-ST; Wed, 30 Oct 2019 10:03:49 +0100 Message-ID: <4b9c7b36f175667a76609c6560618bb48a321ed8.camel@sipsolutions.net> Subject: Re: [PATCH] nl80211: allow more operations for mesh and ad-hoc interfaces From: Johannes Berg To: Markus Theil Cc: linux-wireless@vger.kernel.org Date: Wed, 30 Oct 2019 10:03:48 +0100 In-Reply-To: <20191029115602.78990-1-markus.theil@tu-ilmenau.de> References: <20191029115602.78990-1-markus.theil@tu-ilmenau.de> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, 2019-10-29 at 12:56 +0100, Markus Theil wrote: > This change allows mesh and ad-hoc interfaces to change beacons and > tx queue settings. The direct change of these settings should be ok > for these kind of interfaces and should maybe only forbidden for > station-like interface types. "should maybe"? :-) Not really, both of the changes are wrong. johannes