From: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
To: Vasanthakumar Thiagarajan
<vasanthakumar.thiagarajan@oss.qualcomm.com>,
Aaradhana Sahu <aaradhana.sahu@oss.qualcomm.com>,
ath12k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org, jjohnson@kernel.org,
quic_kiranv@quicinc.com, baochen.qiang@oss.qualcomm.com
Subject: Re: [PATCH ath-next] wifi: ath12k: add support to load shared firmware on multiPD
Date: Wed, 12 Aug 2026 06:57:43 -0700 [thread overview]
Message-ID: <4bd5214b-d2fc-4849-93eb-a088cb8849e2@oss.qualcomm.com> (raw)
In-Reply-To: <c66e03b5-4f49-45e6-ad18-96bb8370cead@oss.qualcomm.com>
On 8/11/2026 2:08 AM, Vasanthakumar Thiagarajan wrote:
> On 8/11/2026 11:13 AM, Aaradhana Sahu wrote:
>> +static int ath12k_ahb_load_auth_shared_fw(struct ath12k_base *ab,
>> + struct ath12k_ahb_rproc_info *rproc_info,
>> + const char *fw_name, u32 pasid)
>> +{
>> + int ret;
>> +
>
> nit: move this empty line below after the declaration part.
>
>> + const struct firmware *fw __free(firmware) = NULL;
Note the when using __free() the declaration should be contiguous with the
assignment, so the current format is correct. That is one exception to the
rule about having declarations separate from code.
/jeff
next prev parent reply other threads:[~2026-08-12 13:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-11 5:43 [PATCH ath-next] wifi: ath12k: add support to load shared firmware on multiPD Aaradhana Sahu
2026-08-11 9:08 ` Vasanthakumar Thiagarajan
2026-08-12 13:57 ` Jeff Johnson [this message]
2026-08-12 2:03 ` Baochen Qiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4bd5214b-d2fc-4849-93eb-a088cb8849e2@oss.qualcomm.com \
--to=jeff.johnson@oss.qualcomm.com \
--cc=aaradhana.sahu@oss.qualcomm.com \
--cc=ath12k@lists.infradead.org \
--cc=baochen.qiang@oss.qualcomm.com \
--cc=jjohnson@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_kiranv@quicinc.com \
--cc=vasanthakumar.thiagarajan@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox