From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93D37C433EF for ; Mon, 28 Mar 2022 07:01:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238649AbiC1HC5 (ORCPT ); Mon, 28 Mar 2022 03:02:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37090 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234808AbiC1HCv (ORCPT ); Mon, 28 Mar 2022 03:02:51 -0400 X-Greylist: delayed 1499 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Mon, 28 Mar 2022 00:01:11 PDT Received: from gateway24.websitewelcome.com (gateway24.websitewelcome.com [192.185.51.251]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7DDE0115D for ; Mon, 28 Mar 2022 00:01:11 -0700 (PDT) Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway24.websitewelcome.com (Postfix) with ESMTP id DFBA31A3C for ; Mon, 28 Mar 2022 01:15:26 -0500 (CDT) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id Yif0nho70RnrrYif0nvYhO; Mon, 28 Mar 2022 01:15:26 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=jQgqtKv6g3c9JTlzvFF9fkILdnQrG04PzWMmUtyZ79I=; b=Z9m6Uy21YEhtJzNbcBVhcTYQYn vTB3fNlc3MOfcSh6ksPbcbYt3oSXkofi5a6lRQPC05JtMruK8znKUKiTTX3akYnERi0THt5V62b9k O3i2yVX8iGTxxGcpJ47nvcy0wCRN019I5YMj117403A7hpVRofIkzeD8LQgrGrmdIpYLwgqyOAlD/ AW2eJjvcAFsrsOMELIVWO1G++G5f5/H22dbAqQ8Ex3v0lYALkLQtX6V/okDZ43zfuA2OfLBspZOEH Bw9+aSG4L4fcfrJe4f2a4dwsO/Uoddhuvu6U0FDkQ06+RWGTnrDTKhOxrvlY2iBr2UTk1rSe/pNCM ikLFO6lA==; Received: from 187-162-31-110.static.axtel.net ([187.162.31.110]:38018 helo=[192.168.15.9]) by gator4166.hostgator.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1nYif0-000lJi-7y; Mon, 28 Mar 2022 01:15:26 -0500 Message-ID: <4c520e2e-d1a5-6d2b-3ef1-b891d7946c01@embeddedor.com> Date: Mon, 28 Mar 2022 01:23:59 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH][next] iwlwifi: fw: Replace zero-length arrays with flexible-array members Content-Language: en-US To: Kalle Valo , "Gustavo A. R. Silva" Cc: Kees Cook , Luca Coelho , "David S. Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org References: <20220216195015.GA904148@embeddedor> <202202161235.2FB20E6A5@keescook> <20220326003843.GA2602091@embeddedor> <871qym1vck.fsf@kernel.org> From: "Gustavo A. R. Silva" In-Reply-To: <871qym1vck.fsf@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 187.162.31.110 X-Source-L: No X-Exim-ID: 1nYif0-000lJi-7y X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 187-162-31-110.static.axtel.net ([192.168.15.9]) [187.162.31.110]:38018 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 4 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 3/28/22 00:47, Kalle Valo wrote: > "Gustavo A. R. Silva" writes: > >> On Wed, Feb 16, 2022 at 12:35:14PM -0800, Kees Cook wrote: >>> On Wed, Feb 16, 2022 at 01:50:15PM -0600, Gustavo A. R. Silva wrote: >>>> There is a regular need in the kernel to provide a way to declare >>>> having a dynamically sized set of trailing elements in a structure. >>>> Kernel code should always use “flexible array members”[1] for these >>>> cases. The older style of one-element or zero-length arrays should >>>> no longer be used[2]. >>>> >>>> [1] https://en.wikipedia.org/wiki/Flexible_array_member >>>> [2] >>>> https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays >>>> >>>> Link: https://github.com/KSPP/linux/issues/78 >>>> Signed-off-by: Gustavo A. R. Silva >>> >>> Reviewed-by: Kees Cook >> >> Hi all, >> >> Friendly ping: can someone take this, please? >> >> ...I can take this in my -next tree in the meantime. > > Like we have discussed before, please don't take any wireless patches to > your tree. The conflicts just cause more work of us. Sure thing. I just removed it from my tree. I didn't get any reply from wireless people in more than a month, and that's why I temporarily took it in my tree so it doesn't get lost. :) > I assigned this patch to me on patchwork and I'm planning to take it to > wireless-next once it opens. Luca, ack? Awesome. Thanks -- Gustavo