From: Ping-Ke Shih <pkshih@realtek.com>
To: Kalle Valo <kvalo@kernel.org>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [PATCH v2 3/5] wifi: rtw89: configure TX path via H2C command
Date: Thu, 8 Sep 2022 07:44:58 +0000 [thread overview]
Message-ID: <4c88051556a64011a0a59d962f1d5f45@realtek.com> (raw)
In-Reply-To: <87r10mbazi.fsf@kernel.org>
> -----Original Message-----
> From: Kalle Valo <kvalo@kernel.org>
> Sent: Thursday, September 8, 2022 3:07 PM
> To: Ping-Ke Shih <pkshih@realtek.com>
> Cc: linux-wireless@vger.kernel.org
> Subject: Re: [PATCH v2 3/5] wifi: rtw89: configure TX path via H2C command
>
> Ping-Ke Shih <pkshih@realtek.com> writes:
>
> > In order to support TX diversity, add a function to control TX path.
> >
> > Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
>
> [...]
>
> > + ret = rtw89_h2c_tx(rtwdev, skb, false);
> > + if (ret) {
> > + rtw89_err(rtwdev, "failed to send h2c\n");
> > + goto fail;
> > + }
> > +
> > + return 0;
> > +fail:
> > + dev_kfree_skb_any(skb);
> > +
> > + return -EBUSY;
>
> Overwriting error codes is confusing, so it would be better that this is
> 'return ret'.
>
Sorry for the mistakes. Fixed by v3.
next prev parent reply other threads:[~2022-09-08 7:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 8:43 [PATCH v2 0/5] wifi: rtw89: support TX diversity for 1T2R variant model Ping-Ke Shih
2022-09-07 8:43 ` [PATCH v2 1/5] wifi: rtw89: use u32_get_bits to access C2H content of PHY capability Ping-Ke Shih
2022-09-07 8:43 ` [PATCH v2 2/5] wifi: rtw89: parse phycap of TX/RX antenna number Ping-Ke Shih
2022-09-07 8:44 ` [PATCH v2 3/5] wifi: rtw89: configure TX path via H2C command Ping-Ke Shih
2022-09-08 7:07 ` Kalle Valo
2022-09-08 7:44 ` Ping-Ke Shih [this message]
2022-09-07 8:44 ` [PATCH v2 4/5] wifi: rtw89: record signal strength per RF path Ping-Ke Shih
2022-09-07 8:44 ` [PATCH v2 5/5] wifi: rtw89: support TX diversity for 1T2R chipset Ping-Ke Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c88051556a64011a0a59d962f1d5f45@realtek.com \
--to=pkshih@realtek.com \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox