RE: [PATCH] wifiwifi: Realtek: rtl8xxxu Add new device ID

[Ping-Ke Shih <pkshih@realtek.com>]

> -----Original Message-----
> From: ZeroBeat <ZeroBeat@gmx.de>
> Sent: Wednesday, December 6, 2023 7:48 PM
> To: linux-wireless@vger.kernel.org
> Cc: Jes.Sorensen@gmail.com
> Subject: [PATCH] wifiwifi: Realtek: rtl8xxxu Add new device ID

subject prefix should be "wifi: rtl8xxxu: ..."

> 
> From: Michael Dieckmann (https://github.com/ZerBea)
> To: linux-wireless
> 
> Subject: [PATCH] wifi: Realtek: rtl8xxxu Add new device ID
> 
> This patch will add a new device ID.
> Patch will close: https://bugzilla.kernel.org/show_bug.cgi?id=218231
> 
> 
> TP-Link TL-WN8200ND(UN) v3.0
> ID 2357:0126 TP-Link 802.11n NIC
> https://www.tp-link.com/de/home-networking/adapter/tl-wn8200nd/
> Sold in Germany.

Missed your sign-of-by, and this patch looks irregular. 
Please reference to https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

> 
> 
> --- linux/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c.orig	2023-12-06 12:38:51.929484252
> +0100
> +++ linux/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c	2023-12-06 11:54:12.524302276 +0100

The directory path is incorrect. 

> @@ -7957,6 +7957,8 @@ static const struct usb_device_id dev_ta
>   /* found in rtl8192eu vendor driver */
>   {USB_DEVICE_AND_INTERFACE_INFO(0x2357, 0x0107, 0xff, 0xff, 0xff),
>   	.driver_info = (unsigned long)&rtl8192eu_fops},
> +{USB_DEVICE_AND_INTERFACE_INFO(0x2357, 0x0126, 0xff, 0xff, 0xff),
> +	.driver_info = (unsigned long)&rtl8192eu_fops},

The indentation is different from other existing ones. 

>   {USB_DEVICE_AND_INTERFACE_INFO(0x2019, 0xab33, 0xff, 0xff, 0xff),
>   	.driver_info = (unsigned long)&rtl8192eu_fops},
>   {USB_DEVICE_AND_INTERFACE_INFO(USB_VENDOR_ID_REALTEK, 0x818c, 0xff, 0xff, 0xff),
> 
> 
> Thanks for maintaining this driver.
> Best regards
> Michael Dieckmann