From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Gokul Sivakumar <gokulkumar.sivakumar@infineon.com>
Cc: brcm80211-dev-list.pdl@broadcom.com, brcm80211@lists.linux.dev,
chris@streetlogic.pro, linux-wireless@vger.kernel.org,
richard@govivid.ai, s311332@gmail.com, wahrenst@gmx.net,
wlan-kernel-dev-list@infineon.com, johannes@sipsolutions.net
Subject: Re: [PATCH wireless-next] wifi: brcmfmac: fix crash while sending Action Frames in standalone AP Mode
Date: Mon, 13 Oct 2025 11:26:01 +0200 [thread overview]
Message-ID: <4d24f3ed-0b7d-45cb-9dfc-b8b5e0b37fd2@broadcom.com> (raw)
In-Reply-To: <aOyqOnKEnkNqfg9u@ISCN5CG14747PP.infineon.com>
On 10/13/2025 9:28 AM, Gokul Sivakumar wrote:
>>> - reinit_completion(&p2p->send_af_done);
>>> + init_completion(&p2p->send_af_done);
>> I think we should not do this here. It used to be init_completion() here
>> but the kernel API changed introducing the reinit_completion() to make
>> explicit distinction between init and reinit. So I would suggest to do
>> the init_completion() in brcmf_p2p_attach() which is always invoked and
>> leave the reinit_completion() here.
> That works too. Will create an updated v2 patch after making this change
> and submit it for the wireless tree instead of wireless-next.
Great.
Thanks,
Arend
next prev parent reply other threads:[~2025-10-13 9:26 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAE3HL_yv8t1Rkd+jLfQMkc3YrNONQp0pRFESV+v92ECf_+7Xjw@mail.gmail.com>
2025-09-24 2:59 ` brcmfmac: driver crash with iOS 18.6.1, potential DoS Hsien Chou
2025-09-25 18:31 ` Arend van Spriel
2025-09-26 1:36 ` Hsien Chou
2025-09-26 12:01 ` Pablo MARTIN-GOMEZ
2025-09-28 18:31 ` Arend van Spriel
2025-09-29 17:06 ` Stefan Wahren
2025-09-29 17:24 ` Chris Spargo
2025-09-29 18:23 ` Arend van Spriel
2025-10-02 23:20 ` [PATCH] brcmfmac: Fix NULL pointer dereference in P2P action frame handling Richard Reigh
2025-10-03 16:00 ` Arend van Spriel
2025-10-03 17:02 ` Stefan Wahren
2025-10-04 9:22 ` Arend van Spriel
2025-10-06 15:47 ` Stefan Wahren
2025-10-06 17:08 ` Richard Reigh
2025-10-06 17:28 ` Stefan Wahren
2025-10-06 18:37 ` Richard Reigh
2025-10-08 18:47 ` Arend van Spriel
2025-10-08 20:21 ` Richard Reigh
2025-10-06 19:41 ` Stefan Wahren
2025-10-06 23:13 ` [PATCH v2] " Richard Reigh
2025-10-07 15:30 ` Gokul Sivakumar
2025-10-08 18:45 ` Arend van Spriel
2025-10-09 7:39 ` [PATCH wireless-next] wifi: brcmfmac: fix crash while sending Action Frames in standalone AP Mode Gokul Sivakumar
2025-10-10 18:35 ` Richard Reigh
2025-10-12 6:15 ` Arend van Spriel
2025-10-12 6:07 ` Arend van Spriel
2025-10-13 7:28 ` Gokul Sivakumar
2025-10-13 9:26 ` Arend van Spriel [this message]
2025-10-13 10:28 ` [PATCH wireless v2] " Gokul Sivakumar
2025-10-13 11:33 ` Arend van Spriel
2025-10-12 6:14 ` [PATCH wireless-next] " Arend van Spriel
2025-10-12 6:12 ` [PATCH v2] brcmfmac: Fix NULL pointer dereference in P2P action frame handling Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d24f3ed-0b7d-45cb-9dfc-b8b5e0b37fd2@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211@lists.linux.dev \
--cc=chris@streetlogic.pro \
--cc=gokulkumar.sivakumar@infineon.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=richard@govivid.ai \
--cc=s311332@gmail.com \
--cc=wahrenst@gmx.net \
--cc=wlan-kernel-dev-list@infineon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).