From: Maharaja Kennadyrajan <mkenna@codeaurora.org>
To: linux-wireless@vger.kernel.org, ath11k@lists.infradead.org
Subject: Re: [PATCH] ath11k: Fix the rx_filter flag setting for peer rssi stats
Date: Tue, 10 Nov 2020 10:29:12 +0530 [thread overview]
Message-ID: <4d2ad5a7a45c1d8c2550ebdbf634d688@codeaurora.org> (raw)
In-Reply-To: <1604408857-5912-1-git-send-email-mkenna@codeaurora.org>
On 2020-11-03 18:37, Maharaja Kennadyrajan wrote:
> Set the rx_filter in ath11k_mac_config_mon_status_default(),
> only when the rx_filter value exists in ath11k_debug_rx_filter().
>
> Without this change, rx_filter gets set to 0 and peer rssi stats
> aren't updating properly from firmware.
>
> Tested-on: IPQ8074 WLAN.HK.2.1.0.1-01230-QCAHKSWPL_SILICONZ-4
>
> Signed-off-by: Maharaja Kennadyrajan <mkenna@codeaurora.org>
> ---
> drivers/net/wireless/ath/ath11k/mac.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath11k/mac.c
> b/drivers/net/wireless/ath/ath11k/mac.c
> index 7f8dd47..c2d013a 100644
> --- a/drivers/net/wireless/ath/ath11k/mac.c
> +++ b/drivers/net/wireless/ath/ath11k/mac.c
> @@ -4094,7 +4094,8 @@ static int
> ath11k_mac_config_mon_status_default(struct ath11k *ar, bool enable)
>
> if (enable) {
> tlv_filter = ath11k_mac_mon_status_filter_default;
> - tlv_filter.rx_filter = ath11k_debugfs_rx_filter(ar);
> + if (ath11k_debug_rx_filter(ar))
> + tlv_filter.rx_filter = ath11k_debug_rx_filter(ar);
> }
>
> for (i = 0; i < ab->hw_params.num_rxmda_per_pdev; i++) {
[Maha]: Hi all, please drop this patch as this patch needs a comment to
be addressed.
I will send v2 patch.
Regards,
Maha
prev parent reply other threads:[~2020-11-10 4:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 13:07 [PATCH] ath11k: Fix the rx_filter flag setting for peer rssi stats Maharaja Kennadyrajan
2020-11-09 13:27 ` kernel test robot
2020-11-10 4:59 ` Maharaja Kennadyrajan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d2ad5a7a45c1d8c2550ebdbf634d688@codeaurora.org \
--to=mkenna@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).