RE: [PATCH v2 1/2] wifi: rtl8xxxu: Support new chip RTL8192FU

[Ping-Ke Shih <pkshih@realtek.com>]

> -----Original Message-----
> From: Bitterblue Smith <rtl8821cerfe2@gmail.com>
> Sent: Wednesday, May 3, 2023 2:39 AM
> To: linux-wireless@vger.kernel.org
> Cc: Jes Sorensen <Jes.Sorensen@gmail.com>; Ping-Ke Shih <pkshih@realtek.com>
> Subject: [PATCH v2 1/2] wifi: rtl8xxxu: Support new chip RTL8192FU
> 
> This is a newer chip, similar to the RTL8710BU in that it uses the same
> PHY status structs.
> 
> Features: 2.4 GHz, b/g/n mode, 2T2R, 300 Mbps.
> 
> It can allegedly have Bluetooth, but that's not implemented here.
> 
> This chip can have many RFE (RF front end) types, of which type 5 is
> the only one tested. Many of the other types need different
> initialisation tables. They can be added if someone wants them.
> 
> The vendor driver v5.8.6.2_35538.20191028_COEX20190910-0d02 from
> https://github.com/BrightX/rtl8192fu was used as reference, with
> additional device IDs taken from
> https://github.com/kelebek333/rtl8192fu-dkms.
> 
> The vendor driver also claims to support devices with ID 0bda:a725,
> but that is found in some bluetooth-only devices, so it's not supported
> here.
> 
> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>

Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>

> ---
> v2:
>  - Feedback from Ping-Ke Shih:
>    - Add rtl8xxxu_8192f.o to Makefile.
>    - Initialise variable channel_idx in rtl8192fu_config_kfree() and
>      variable ledcfg in rtl8192fu_led_brightness_set() to avoid
>      warnings.
>    - Give names to a lot of registers.
>    - Initialise bb_gain_for_path in rtl8192fu_config_kfree() in two
>      steps.
>    - Don't assign the return value of rtl8xxxu_write32_mask() to
>      variable val32 in rtl8xxxu_fill_iqk_matrix_b().
>  - Add more information about device IDs to the commit message.
> ---
>  drivers/net/wireless/realtek/rtl8xxxu/Kconfig |    3 +-
>  .../net/wireless/realtek/rtl8xxxu/Makefile    |    2 +-
>  .../net/wireless/realtek/rtl8xxxu/rtl8xxxu.h  |   47 +
>  .../realtek/rtl8xxxu/rtl8xxxu_8188f.c         |    3 +-
>  .../realtek/rtl8xxxu/rtl8xxxu_8192f.c         | 2090 +++++++++++++++++
>  .../realtek/rtl8xxxu/rtl8xxxu_8710b.c         |    1 +
>  .../realtek/rtl8xxxu/rtl8xxxu_8723b.c         |    1 +
>  .../wireless/realtek/rtl8xxxu/rtl8xxxu_core.c |  104 +-
>  .../wireless/realtek/rtl8xxxu/rtl8xxxu_regs.h |   39 +
>  9 files changed, 2259 insertions(+), 31 deletions(-)
>  create mode 100644 drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192f.c
> 
> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/Kconfig
> b/drivers/net/wireless/realtek/rtl8xxxu/Kconfig
> index 82bcaf44a65f..44ad94757a03 100644

[...]