From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from nbd.name (nbd.name [46.4.11.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5288E34CFA7 for ; Tue, 27 Jan 2026 12:21:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.4.11.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769516478; cv=none; b=M/u9Cmh5BmLauI8wb6/PAU2gI0nqf2nC/QWGGfZMABwwulqhyh5kMjb3gJE48dAjtBKWDqXpHiDUCmOHpX8GEcPAkr/Ird9HlbwWFJo1RVM9AxUrbPsBkn1jYNHc/q9mo38FGsh7qGVCefWn8QqfKAUlHvydupPA+glGmocN/Bc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769516478; c=relaxed/simple; bh=dCc6/Fp//WLMMA0bYwBnBGOH4EIHinYTYrskGPTbr8I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rcSAAO4GBQisYfReiOJMTDAZm6eGQBVLsK6+/ilZLM5gu1YAtjNLC+Mm8/Frf/QUao43LPLkVy1jDuAkRKaC+ZF4WepeK88+PKpbDS4UdEWQR+ui0UUAYhucFz6wg8XQCYzBzhs1YjHX51aqlbtKLfiUd5ckdZrM2xtbVOYWJwo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nbd.name; spf=pass smtp.mailfrom=nbd.name; dkim=pass (1024-bit key) header.d=nbd.name header.i=@nbd.name header.b=X8aU+eKC; arc=none smtp.client-ip=46.4.11.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nbd.name Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nbd.name Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=nbd.name header.i=@nbd.name header.b="X8aU+eKC" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name; s=20160729; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=mWgI1MehsR5Fkoxw406LUnf58LEiCHEf0iUrk8eSYIA=; b=X8aU+eKCy2pDBf2uljNiQGVGLU qYaYKEWRJHTC8w1NdqP/B1mlUTAy78qaQ/rSwvE9HLDl5ZnI6ZKYRrkiNridrKyVWjOY/Irk4RgfN a7WzHfm98P46yA3tWqlbKO9MwVCkAaNNKS8lGmHc+ZmH68h4HRIvmhaaTniwCdZ0R/qE=; Received: from p54a43f8f.dip0.t-ipconnect.de ([84.164.63.143] helo=nf.local) by ds12 with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1vki4G-00Bgu5-1m; Tue, 27 Jan 2026 13:21:12 +0100 Message-ID: <4ddb4417-d623-44ae-878d-5ee5939f2826@nbd.name> Date: Tue, 27 Jan 2026 13:21:11 +0100 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] wifi: mt76: connac: fix txpower_cur not being updated To: Lucid Duck , linux-wireless@vger.kernel.org Cc: Lorenzo Bianconi , Ryder Lee References: <20260125222235.36565-1-lucid_duck@justthetip.ca> Content-Language: en-US From: Felix Fietkau Autocrypt: addr=nbd@nbd.name; keydata= xsDiBEah5CcRBADIY7pu4LIv3jBlyQ/2u87iIZGe6f0f8pyB4UjzfJNXhJb8JylYYRzIOSxh ExKsdLCnJqsG1PY1mqTtoG8sONpwsHr2oJ4itjcGHfn5NJSUGTbtbbxLro13tHkGFCoCr4Z5 Pv+XRgiANSpYlIigiMbOkide6wbggQK32tC20QxUIwCg4k6dtV/4kwEeiOUfErq00TVqIiEE AKcUi4taOuh/PQWx/Ujjl/P1LfJXqLKRPa8PwD4j2yjoc9l+7LptSxJThL9KSu6gtXQjcoR2 vCK0OeYJhgO4kYMI78h1TSaxmtImEAnjFPYJYVsxrhay92jisYc7z5R/76AaELfF6RCjjGeP wdalulG+erWju710Bif7E1yjYVWeA/9Wd1lsOmx6uwwYgNqoFtcAunDaMKi9xVQW18FsUusM TdRvTZLBpoUAy+MajAL+R73TwLq3LnKpIcCwftyQXK5pEDKq57OhxJVv1Q8XkA9Dn1SBOjNB l25vJDFAT9ntp9THeDD2fv15yk4EKpWhu4H00/YX8KkhFsrtUs69+vZQwc0cRmVsaXggRmll dGthdSA8bmJkQG5iZC5uYW1lPsJgBBMRAgAgBQJGoeQnAhsjBgsJCAcDAgQVAggDBBYCAwEC HgECF4AACgkQ130UHQKnbvXsvgCgjsAIIOsY7xZ8VcSm7NABpi91yTMAniMMmH7FRenEAYMa VrwYTIThkTlQzsFNBEah5FQQCACMIep/hTzgPZ9HbCTKm9xN4bZX0JjrqjFem1Nxf3MBM5vN CYGBn8F4sGIzPmLhl4xFeq3k5irVg/YvxSDbQN6NJv8o+tP6zsMeWX2JjtV0P4aDIN1pK2/w VxcicArw0VYdv2ZCarccFBgH2a6GjswqlCqVM3gNIMI8ikzenKcso8YErGGiKYeMEZLwHaxE Y7mTPuOTrWL8uWWRL5mVjhZEVvDez6em/OYvzBwbkhImrryF29e3Po2cfY2n7EKjjr3/141K DHBBdgXlPNfDwROnA5ugjjEBjwkwBQqPpDA7AYPvpHh5vLbZnVGu5CwG7NAsrb2isRmjYoqk wu++3117AAMFB/9S0Sj7qFFQcD4laADVsabTpNNpaV4wAgVTRHKV/kC9luItzwDnUcsZUPdQ f3MueRJ3jIHU0UmRBG3uQftqbZJj3ikhnfvyLmkCNe+/hXhPu9sGvXyi2D4vszICvc1KL4RD aLSrOsROx22eZ26KqcW4ny7+va2FnvjsZgI8h4sDmaLzKczVRIiLITiMpLFEU/VoSv0m1F4B FtRgoiyjFzigWG0MsTdAN6FJzGh4mWWGIlE7o5JraNhnTd+yTUIPtw3ym6l8P+gbvfoZida0 TspgwBWLnXQvP5EDvlZnNaKa/3oBes6z0QdaSOwZCRA3QSLHBwtgUsrT6RxRSweLrcabwkkE GBECAAkFAkah5FQCGwwACgkQ130UHQKnbvW2GgCeMncXpbbWNT2AtoAYICrKyX5R3iMAoMhw cL98efvrjdstUfTCP2pfetyN In-Reply-To: <20260125222235.36565-1-lucid_duck@justthetip.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 25.01.26 23:22, Lucid Duck wrote: > The mt76_connac_mcu_set_rate_txpower() function sends TX power settings > to the firmware but never updates phy->txpower_cur. This causes > mt76_get_txpower() to return stale or incorrect values (typically > showing 3 dBm regardless of actual transmit power) when userspace > queries TX power via nl80211. > > This affects MT7921 and other connac-based devices. Users observe: > $ iw dev wlan0 info > ... > txpower 3.00 dBm > > The firmware receives and applies the correct power level, but the > reported value is wrong because txpower_cur is never set. > > Fix by updating phy->txpower_cur after successfully configuring TX > power, matching the behavior of other mt76 drivers like mt7915. > > Signed-off-by: Lucid Duck > --- > drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c > index 045771228..7cd357419 100644 > --- a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c > +++ b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c > @@ -2251,7 +2251,7 @@ mt76_connac_mcu_rate_txpower_band(struct mt76_phy *phy, > > int mt76_connac_mcu_set_rate_txpower(struct mt76_phy *phy) > { > - int err; > + int err, tx_power; > > if (phy->cap.has_2ghz) { > err = mt76_connac_mcu_rate_txpower_band(phy, > @@ -2272,6 +2272,12 @@ int mt76_connac_mcu_set_rate_txpower(struct mt76_phy *phy) > return err; > } > > + /* Update txpower_cur for accurate reporting via nl80211 */ > + tx_power = 2 * phy->hw->conf.power_level; > + if (!tx_power) > + tx_power = 127; > + phy->txpower_cur = tx_power; phy->hw->conf.power_level is the user configured power level, not what the hardware is capable of transmitting. To fix it properly, I think you should determine the maximum rate power used in the loop within mt76_connac_mcu_rate_txpower_band (updated with each call). - Felix