* [PATCH] wifi: rtw88: unlock on error path in rtw_ops_add_interface()
@ 2023-05-03 15:09 Dan Carpenter
2023-05-04 1:16 ` Ping-Ke Shih
2023-05-11 13:18 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2023-05-03 15:09 UTC (permalink / raw)
To: Po-Hao Huang
Cc: Yan-Hsuan Chuang, Kalle Valo, Ping-Ke Shih, linux-wireless,
kernel-janitors
Call mutex_unlock(&rtwdev->mutex); before returning on this error path.
Fixes: f0e741e4ddbc ("wifi: rtw88: add bitmap for dynamic port settings")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/net/wireless/realtek/rtw88/mac80211.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtw88/mac80211.c b/drivers/net/wireless/realtek/rtw88/mac80211.c
index 7aa6edad0d01..02cd19ee6e4c 100644
--- a/drivers/net/wireless/realtek/rtw88/mac80211.c
+++ b/drivers/net/wireless/realtek/rtw88/mac80211.c
@@ -173,8 +173,10 @@ static int rtw_ops_add_interface(struct ieee80211_hw *hw,
mutex_lock(&rtwdev->mutex);
port = find_first_zero_bit(rtwdev->hw_port, RTW_PORT_NUM);
- if (port >= RTW_PORT_NUM)
+ if (port >= RTW_PORT_NUM) {
+ mutex_unlock(&rtwdev->mutex);
return -EINVAL;
+ }
set_bit(port, rtwdev->hw_port);
rtwvif->port = port;
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] wifi: rtw88: unlock on error path in rtw_ops_add_interface()
2023-05-03 15:09 [PATCH] wifi: rtw88: unlock on error path in rtw_ops_add_interface() Dan Carpenter
@ 2023-05-04 1:16 ` Ping-Ke Shih
2023-05-11 13:18 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Ping-Ke Shih @ 2023-05-04 1:16 UTC (permalink / raw)
To: Dan Carpenter, Bernie Huang
Cc: Yan-Hsuan Chuang, Kalle Valo, linux-wireless@vger.kernel.org,
kernel-janitors@vger.kernel.org
> -----Original Message-----
> From: Dan Carpenter <dan.carpenter@linaro.org>
> Sent: Wednesday, May 3, 2023 11:10 PM
> To: Bernie Huang <phhuang@realtek.com>
> Cc: Yan-Hsuan Chuang <tony0620emma@gmail.com>; Kalle Valo <kvalo@kernel.org>; Ping-Ke Shih
> <pkshih@realtek.com>; linux-wireless@vger.kernel.org; kernel-janitors@vger.kernel.org
> Subject: [PATCH] wifi: rtw88: unlock on error path in rtw_ops_add_interface()
>
> Call mutex_unlock(&rtwdev->mutex); before returning on this error path.
>
> Fixes: f0e741e4ddbc ("wifi: rtw88: add bitmap for dynamic port settings")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>
[...]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] wifi: rtw88: unlock on error path in rtw_ops_add_interface()
2023-05-03 15:09 [PATCH] wifi: rtw88: unlock on error path in rtw_ops_add_interface() Dan Carpenter
2023-05-04 1:16 ` Ping-Ke Shih
@ 2023-05-11 13:18 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2023-05-11 13:18 UTC (permalink / raw)
To: Dan Carpenter
Cc: Po-Hao Huang, Yan-Hsuan Chuang, Ping-Ke Shih, linux-wireless,
kernel-janitors
Dan Carpenter <dan.carpenter@linaro.org> wrote:
> Call mutex_unlock(&rtwdev->mutex); before returning on this error path.
>
> Fixes: f0e741e4ddbc ("wifi: rtw88: add bitmap for dynamic port settings")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>
Patch applied to wireless-next.git, thanks.
e2ff1181b3d4 wifi: rtw88: unlock on error path in rtw_ops_add_interface()
--
https://patchwork.kernel.org/project/linux-wireless/patch/ddd10a74-5982-4f65-8c59-c1cca558d239@kili.mountain/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-05-11 13:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-03 15:09 [PATCH] wifi: rtw88: unlock on error path in rtw_ops_add_interface() Dan Carpenter
2023-05-04 1:16 ` Ping-Ke Shih
2023-05-11 13:18 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).