Linux wireless drivers development
 help / color / mirror / Atom feed
From: Ping-Ke Shih <pkshih@realtek.com>
To: Fiona Klute <fiona.klute@gmx.de>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: Vasily Khoruzhick <anarsoul@gmail.com>,
	Kalle Valo <kvalo@kernel.org>,
	Bitterblue Smith <rtl8821cerfe2@gmail.com>,
	Ondrej Jirman <megi@xff.cz>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: RE: [PATCH] wifi: rtw88: sdio: Fix disconnection after beacon loss
Date: Tue, 7 Jan 2025 00:27:43 +0000	[thread overview]
Message-ID: <4f1064c7b97b47de88b17c647e4a41c3@realtek.com> (raw)
In-Reply-To: <20250106135434.35936-1-fiona.klute@gmx.de>

Fiona Klute <fiona.klute@gmx.de> wrote:
> This is the equivalent of 28818b4d871bc93cc4f5c7c7d7c526a6a096c09c

Normally use 12 digits as pattern like: 

Commit 28818b4d871b ("wifi: rtw88: usb: Fix disconnection after beacon loss")

I can spin this during merging. 

> "wifi: rtw88: usb: Fix disconnection after beacon loss" for SDIO
> chips. Tested on Pinephone (RTL8723CS), random disconnections became
> rare, instead of a frequent nuisance.
> 
> Cc: stable@vger.kernel.org
> Signed-off-by: Fiona Klute <fiona.klute@gmx.de>

Acked-by: Ping-Ke Shih <pkshih@realtek.com>

> ---
>  drivers/net/wireless/realtek/rtw88/sdio.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/wireless/realtek/rtw88/sdio.c b/drivers/net/wireless/realtek/rtw88/sdio.c
> index 799230eb5f1..e024061bdbf 100644
> --- a/drivers/net/wireless/realtek/rtw88/sdio.c
> +++ b/drivers/net/wireless/realtek/rtw88/sdio.c
> @@ -1192,6 +1192,8 @@ static void rtw_sdio_indicate_tx_status(struct rtw_dev *rtwdev,
>         struct ieee80211_tx_info *info = IEEE80211_SKB_CB(skb);
>         struct ieee80211_hw *hw = rtwdev->hw;
> 
> +       skb_pull(skb, rtwdev->chip->tx_pkt_desc_sz);
> +
>         /* enqueue to wait for tx report */
>         if (info->flags & IEEE80211_TX_CTL_REQ_TX_STATUS) {
>                 rtw_tx_report_enqueue(rtwdev, skb, tx_data->sn);
> --
> 2.47.1


  parent reply	other threads:[~2025-01-07  0:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-06 13:54 [PATCH] wifi: rtw88: sdio: Fix disconnection after beacon loss Fiona Klute
2025-01-06 18:01 ` Vasily Khoruzhick
2025-01-07  0:27 ` Ping-Ke Shih [this message]
2025-01-12  2:06 ` Ping-Ke Shih

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4f1064c7b97b47de88b17c647e4a41c3@realtek.com \
    --to=pkshih@realtek.com \
    --cc=anarsoul@gmail.com \
    --cc=fiona.klute@gmx.de \
    --cc=kvalo@kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=megi@xff.cz \
    --cc=rtl8821cerfe2@gmail.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox