From: Thomas Huehn <thomas@net.t-labs.tu-berlin.de>
To: Bob Copeland <me@bobcopeland.com>
Cc: jirislaby@gmail.com, johannes.berg@intel.com,
ath5k-devel@lists.ath5k.org, linux-wireless@vger.kernel.org,
linville@tuxdriver.com, nbd@nbd.name
Subject: Re: [ath5k-devel] [PATCH 2/2] ath5k: fix phy_init() to respect user txpower changes
Date: Mon, 23 Jul 2012 20:25:26 +0200 [thread overview]
Message-ID: <500D9716.10300@net.t-labs.tu-berlin.de> (raw)
In-Reply-To: <20120723164250.GA11893@localhost>
Hi Bob,
Bob Copeland schrieb:
> On Mon, Jul 23, 2012 at 06:01:15PM +0200, Thomas Huehn wrote:
>> /* Setup rate power table */
>> - ath5k_setup_rate_powertable(ah, txpower, &rate_info, ee_mode);
>> + ath5k_setup_rate_powertable(ah, ah->ah_txpower.txp_user_pwr, &rate_info, ee_mode);
>
> txpower used to be .5 dB units -- is it still?
ah->ah_txpower.txp_user_pwr is now in 1dB units, as it is triggered from
mac802.11
>> - ret = ath5k_hw_txpower(ah, channel, ah->ah_txpower.txp_cur_pwr ?
>> - ah->ah_txpower.txp_cur_pwr / 2 : AR5K_TUNE_MAX_TXPOWER);
>> + ret = ath5k_hw_txpower(ah, channel);
>> +
>
> Did this / 2 move elsewhere or was it wrong before? Is txp_cur_pwr still
> used for anything?
the "/2" is not needed anymore as I also skipped the "*2" in
ath5k_hw_set_txpower_limit .. so I avoid this calculations.
Felix is goint to use txp_cur_pwr, so for now it is not used ... maybe
he can explain where it will be needed.
Greetings Thomas
next prev parent reply other threads:[~2012-07-23 18:25 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-23 16:01 [PATCH 0/2] ath5k: fixing broken power gain calibration at 5GHz and txpower handling Thomas Huehn
2012-07-23 16:01 ` [PATCH 1/2] ath5k: fix wrong per rate target power eeprom reads for AR5K_EEPROM_MODE_11A Thomas Huehn
2012-07-25 18:42 ` Nick Kossifidis
2012-07-25 18:55 ` Felix Fietkau
2012-07-25 22:22 ` Nick Kossifidis
2012-07-25 22:01 ` [ath5k-devel] " Thomas Huehn
2012-07-25 22:31 ` Nick Kossifidis
2012-08-04 8:14 ` Thomas Huehn
2012-08-04 15:28 ` Nick Kossifidis
2012-08-05 11:06 ` Thomas Huehn
2012-08-05 11:56 ` Nick Kossifidis
2012-08-05 12:37 ` Thomas Huehn
2012-08-05 12:59 ` Nick Kossifidis
2012-08-05 18:26 ` Nick Kossifidis
2012-07-23 16:01 ` [PATCH 2/2] ath5k: fix phy_init() to respect user txpower changes Thomas Huehn
2012-07-23 16:42 ` [ath5k-devel] " Bob Copeland
2012-07-23 18:25 ` Thomas Huehn [this message]
2012-07-23 18:29 ` Thomas Huehn
2012-07-23 19:20 ` Bob Copeland
2012-07-25 19:22 ` Nick Kossifidis
2012-07-25 23:07 ` Thomas Huehn
2012-07-25 23:23 ` Nick Kossifidis
2012-07-25 23:40 ` [ath5k-devel] " Thomas Huehn
2012-07-26 10:20 ` Nick Kossifidis
2012-07-26 10:28 ` Felix Fietkau
2012-07-26 10:31 ` Nick Kossifidis
2012-07-26 10:41 ` Felix Fietkau
2012-07-26 17:48 ` Nick Kossifidis
2012-07-26 20:56 ` Thomas Huehn
2012-07-28 11:45 ` Nick Kossifidis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500D9716.10300@net.t-labs.tu-berlin.de \
--to=thomas@net.t-labs.tu-berlin.de \
--cc=ath5k-devel@lists.ath5k.org \
--cc=jirislaby@gmail.com \
--cc=johannes.berg@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=me@bobcopeland.com \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).