[REGRESSION][v3.5] iwlwifi: include rssi as part of decision making for reduce txpower

[REGRESSION][v3.5] iwlwifi: include rssi as part of decision making for reduce txpower

[Joseph Salisbury]

Hello,

A bug[0] was reported against Ubuntu that reports a kernel panic when 
using the hotkey to disable then re-enable wifi on a Dell XPS 14z.  A 
kernel bisect was performed, which indicated the following commit as the 
source of the regression:


commit dd551ab7b47ace14753b0d73f79437cc35adcf6b
Author: Wey-Yi Guy <wey-yi.w.guy@intel.com>
Date:   Thu May 3 14:22:01 2012 -0700

     iwlwifi: include rssi as part of decision making for reduce txpower

     In bt coex, consider the average rssi as part of decision making 
process

     Change-Id: I8d11d7f177a6875e2a9d08f7539d42253226fd7a
     Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
     Reviewed-on: http://git-mwg.jer.intel.com/gerrit/1945
     Tested-by: Jenkins
     Reviewed-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
     Signed-off-by: John W. Linville <linville@tuxdriver.com>

A test kernel was created with this commit reverted, which stopped the 
kernel panic from occurring.

A bugzilla bug[1] has been opened.

Thanks,

Joe


[0] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1029547
[1] https://bugzilla.kernel.org/show_bug.cgi?id=45491

Re: [REGRESSION][v3.5] iwlwifi: include rssi as part of decision making for reduce txpower

[Johannes Berg]

On Fri, 2012-08-03 at 12:24 -0400, Joseph Salisbury wrote:

> A test kernel was created with this commit reverted, which stopped the 
> kernel panic from occurring.
> 
> A bugzilla bug[1] has been opened.

> [0] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1029547
> [1] https://bugzilla.kernel.org/show_bug.cgi?id=45491

This is a duplicate of https://bugzilla.kernel.org/show_bug.cgi?id=45481
which I've already commented on with the correct fix. I've also sent the
fix to stable:

http://www.mail-archive.com/stable@vger.kernel.org/msg12286.html

Thanks,
johannes

Re: [REGRESSION][v3.5] iwlwifi: include rssi as part of decision making for reduce txpower

[Joseph Salisbury]

On 08/03/2012 12:30 PM, Johannes Berg wrote:
> On Fri, 2012-08-03 at 12:24 -0400, Joseph Salisbury wrote:
>
>> A test kernel was created with this commit reverted, which stopped the
>> kernel panic from occurring.
>>
>> A bugzilla bug[1] has been opened.
>> [0] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1029547
>> [1] https://bugzilla.kernel.org/show_bug.cgi?id=45491
> This is a duplicate of https://bugzilla.kernel.org/show_bug.cgi?id=45481
> which I've already commented on with the correct fix. I've also sent the
> fix to stable:
>
> http://www.mail-archive.com/stable@vger.kernel.org/msg12286.html
>
> Thanks,
> johannes
>
Great!  Thanks for the feedback, Johannes.