From: Thomas Huehn <thomas@net.t-labs.tu-berlin.de>
To: Nick Kossifidis <mickflemm@gmail.com>
Cc: nbd@nbd.name, jirislaby@gmail.com,
linux-wireless@vger.kernel.org, mcgrof@qca.qualcomm.com,
ath5k-devel@lists.ath5k.org, Bob Copeland <me@bobcopeland.com>
Subject: Re: [ath5k-devel] [PATCH 1/2] ath5k: fix wrong per rate target power eeprom reads for AR5K_EEPROM_MODE_11A
Date: Sun, 05 Aug 2012 14:37:02 +0200 [thread overview]
Message-ID: <501E68EE.1060000@net.t-labs.tu-berlin.de> (raw)
In-Reply-To: <CAFtRNNyXgrzsB8Od+qqLgRSb3o_KkxD4sG3UOzu5C1Sz06-GkA@mail.gmail.com>
Hi Nick
> According to EEPROM docs there are 10 calibration piers on all chips
> after 5111 for 11a but some of them are not used and the way to test
> this is if frequency is zero. Now here is a bug in the EEPROM code
> that might result the wrong reads you get, check this out:
>
> on ath5k_eeprom_read_freq_list we do this
>
> if (!freq1)
> break;
>
> instead of this
>
> if (!freq1)
> continue;
That did the trick !
So reading 10 calibration piers and using the fix from above works in
terms of tx_power changes on CM9 and DCMA82 are properly used by the
hardware.
I will send a patch for that.
Greetings Thomas
next prev parent reply other threads:[~2012-08-05 12:37 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-23 16:01 [PATCH 0/2] ath5k: fixing broken power gain calibration at 5GHz and txpower handling Thomas Huehn
2012-07-23 16:01 ` [PATCH 1/2] ath5k: fix wrong per rate target power eeprom reads for AR5K_EEPROM_MODE_11A Thomas Huehn
2012-07-25 18:42 ` Nick Kossifidis
2012-07-25 18:55 ` Felix Fietkau
2012-07-25 22:22 ` Nick Kossifidis
2012-07-25 22:01 ` [ath5k-devel] " Thomas Huehn
2012-07-25 22:31 ` Nick Kossifidis
2012-08-04 8:14 ` Thomas Huehn
2012-08-04 15:28 ` Nick Kossifidis
2012-08-05 11:06 ` Thomas Huehn
2012-08-05 11:56 ` Nick Kossifidis
2012-08-05 12:37 ` Thomas Huehn [this message]
2012-08-05 12:59 ` Nick Kossifidis
2012-08-05 18:26 ` Nick Kossifidis
2012-07-23 16:01 ` [PATCH 2/2] ath5k: fix phy_init() to respect user txpower changes Thomas Huehn
2012-07-23 16:42 ` [ath5k-devel] " Bob Copeland
2012-07-23 18:25 ` Thomas Huehn
2012-07-23 18:29 ` Thomas Huehn
2012-07-23 19:20 ` Bob Copeland
2012-07-25 19:22 ` Nick Kossifidis
2012-07-25 23:07 ` Thomas Huehn
2012-07-25 23:23 ` Nick Kossifidis
2012-07-25 23:40 ` [ath5k-devel] " Thomas Huehn
2012-07-26 10:20 ` Nick Kossifidis
2012-07-26 10:28 ` Felix Fietkau
2012-07-26 10:31 ` Nick Kossifidis
2012-07-26 10:41 ` Felix Fietkau
2012-07-26 17:48 ` Nick Kossifidis
2012-07-26 20:56 ` Thomas Huehn
2012-07-28 11:45 ` Nick Kossifidis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=501E68EE.1060000@net.t-labs.tu-berlin.de \
--to=thomas@net.t-labs.tu-berlin.de \
--cc=ath5k-devel@lists.ath5k.org \
--cc=jirislaby@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@qca.qualcomm.com \
--cc=me@bobcopeland.com \
--cc=mickflemm@gmail.com \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).