From: Mahesh Palivela <maheshp@posedge.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Srinivasan B <srinivasanb@posedge.com>, <linville@tuxdriver.com>,
<linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] cfg80211: Fix for crash in cfg80211
Date: Tue, 7 Aug 2012 18:52:30 +0530 [thread overview]
Message-ID: <50211696.40607@posedge.com> (raw)
In-Reply-To: <1344339753.15172.0.camel@jlt3.sipsolutions.net>
On 8/7/2012 5:12 PM, Johannes Berg wrote:
> On Tue, 2012-08-07 at 12:40 +0530, Srinivasan B wrote:
>> Patch Description:
>> cfg80211 module crashes when cfg80211 & mac80211
>> loaded and unloading lmac driver.
>>
>> Scenario Explanation:
>> (Step 1) : cfg80211, mac80211 and lmac driver
>> modules are loaded initially.
>> (Step 2) : unload the lmac driver.
>> then any dev calls to stack causes
>> the crash.
>> Code Changes:
>> dev->ethtools_ops is assigned during
>> NETDEV_REGISTER and the same can be cleared during NETDEV_UNREGISTER.
>
> This doesn't make any sense to me at all.
>
cleanup of ethtools_ops pointer is required upon netdev_unreg
notification. we are assigning this pointer to cfg80211_ethtool_ops on
netdev_reg notification. Is it not required?
we have seen crash when keeping cfg80211 and mac80211 loaded and lmac
driver unloaded. With this fix, we didn't see crash. Crash doesn't
happen right away. Only when some operation trying to access ethtool_ops.
> johannes
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2012-08-07 13:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-07 7:10 [PATCH] cfg80211: Fix for crash in cfg80211 Srinivasan B
2012-08-07 11:42 ` Johannes Berg
2012-08-07 13:22 ` Mahesh Palivela [this message]
2012-08-07 16:20 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50211696.40607@posedge.com \
--to=maheshp@posedge.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=srinivasanb@posedge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).