From: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
To: Sujith Manoharan <c_manoha@qca.qualcomm.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
<linux-wireless@vger.kernel.org>,
Rodriguez Luis <rodrigue@qca.qualcomm.com>,
<ath9k-devel@lists.ath9k.org>
Subject: Re: [RFC 3/3] ath9k_htc: Remove interface combination specific checks
Date: Tue, 14 Aug 2012 10:32:47 +0530 [thread overview]
Message-ID: <5029DBF7.8060402@qca.qualcomm.com> (raw)
In-Reply-To: <20521.8077.412278.460752@gargle.gargle.HOWL>
On Monday 13 August 2012 09:08 PM, Sujith Manoharan wrote:
> Mohammed Shafi Shajakhan wrote:
>> - if (priv->nvifs >= ATH9K_HTC_MAX_VIF) {
>> - mutex_unlock(&priv->mutex);
>> - return -ENOBUFS;
>> - }
>> -
>> - if (priv->num_ibss_vif ||
>> - (priv->nvifs && vif->type == NL80211_IFTYPE_ADHOC)) {
>> - ath_err(common, "IBSS coexistence with other modes is not allowed\n");
>> - mutex_unlock(&priv->mutex);
>> - return -ENOBUFS;
>> - }
>> -
>> - if (((vif->type == NL80211_IFTYPE_AP) ||
>> - (vif->type == NL80211_IFTYPE_ADHOC)) &&
>> - ((priv->num_ap_vif + priv->num_ibss_vif) >= ATH9K_HTC_MAX_BCN_VIF)) {
>> - ath_err(common, "Max. number of beaconing interfaces reached\n");
>> - mutex_unlock(&priv->mutex);
>> - return -ENOBUFS;
>> - }
>> -
>
> Looks okay.
thanks for the review!
>
> Sujith
>
--
thanks,
shafi
prev parent reply other threads:[~2012-08-14 5:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-13 15:23 [RFC 3/3] ath9k_htc: Remove interface combination specific checks Mohammed Shafi Shajakhan
2012-08-13 15:38 ` Sujith Manoharan
2012-08-14 5:02 ` Mohammed Shafi Shajakhan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5029DBF7.8060402@qca.qualcomm.com \
--to=mohammed@qca.qualcomm.com \
--cc=ath9k-devel@lists.ath9k.org \
--cc=c_manoha@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=rodrigue@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).