From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Thomas Pedersen <c_tpeder@qca.qualcomm.com>
Cc: <ath6kl-devel@qualcomm.com>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ath6kl: rework scheduled scan
Date: Mon, 20 Aug 2012 09:52:50 +0300 [thread overview]
Message-ID: <5031DEC2.9020103@qca.qualcomm.com> (raw)
In-Reply-To: <1345074684-4662-1-git-send-email-c_tpeder@qca.qualcomm.com>
On 08/16/2012 02:51 AM, Thomas Pedersen wrote:
> This patch reflects changes in the firmware scheduled scan
> implementation to behave better in cases with multiple concurrent vifs.
> Major changes:
>
> - scheduled scan filters and state are now programmed per-vif.
> - decouple scheduled scan from host sleep.
>
> To maintain graceful failure with old firmwares, a new firmware
> capability bit is introduced: ATH6KL_FW_CAPABILITY_SCHED_SCAN_V2.
> ath6kl simply won't advertise scheduled scan to cfg80211 if the
> SCHED_SCAN_V2 is not supported.
>
> Since firmwares from here on out won't support the previous implicit API
> for scheduled scan (set WoW filters and host sleep), bump the firmware
> API to protect old drivers.
Patch looks good but it doesn't apply. Can you rebase and resend, please?
> Unfortunately, due to firmware RAM constraints ath6kl still cannot
> expect a scan complete event at the end of a scheduled scan results
> cycle, so the sched_scan_timer is retained.
This is indeed unfortunate. I was so hoping to get rid of the ugly timer.
BTW, whenever you can try to avoid using any custom commits when
submitting patches upstream, that way it's easier to fix conflicts with
3-way merge:
Applying: ath6kl: configure wow filters per-vif
fatal: sha1 information is lacking or useless
(drivers/net/wireless/ath/ath6kl/cfg80211.c).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Kalle
next prev parent reply other threads:[~2012-08-20 6:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-15 23:51 [PATCH] ath6kl: rework scheduled scan Thomas Pedersen
2012-08-20 6:52 ` Kalle Valo [this message]
2012-08-20 7:04 ` Kalle Valo
2012-08-20 7:05 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5031DEC2.9020103@qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath6kl-devel@qualcomm.com \
--cc=c_tpeder@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).