* [PATCH] rtlwifi: rtl8192de: remove pointless conditional before kfree_skb()
@ 2012-08-28 13:11 Wei Yongjun
2012-08-28 14:44 ` Larry Finger
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2012-08-28 13:11 UTC (permalink / raw)
To: Larry.Finger, chaoming_li, linville; +Cc: yongjun_wei, linux-wireless, netdev
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Remove pointless conditional before kfree_skb().
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/net/wireless/rtlwifi/rtl8192de/fw.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/rtlwifi/rtl8192de/fw.c b/drivers/net/wireless/rtlwifi/rtl8192de/fw.c
index 895ae6c..a3aede0 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192de/fw.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192de/fw.c
@@ -570,8 +570,7 @@ static bool _rtl92d_cmd_send_packet(struct ieee80211_hw *hw,
ring = &rtlpci->tx_ring[BEACON_QUEUE];
pskb = __skb_dequeue(&ring->queue);
- if (pskb)
- kfree_skb(pskb);
+ kfree_skb(pskb);
spin_lock_irqsave(&rtlpriv->locks.irq_th_lock, flags);
pdesc = &ring->desc[idx];
/* discard output from call below */
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rtlwifi: rtl8192de: remove pointless conditional before kfree_skb()
2012-08-28 13:11 [PATCH] rtlwifi: rtl8192de: remove pointless conditional before kfree_skb() Wei Yongjun
@ 2012-08-28 14:44 ` Larry Finger
0 siblings, 0 replies; 2+ messages in thread
From: Larry Finger @ 2012-08-28 14:44 UTC (permalink / raw)
To: Wei Yongjun; +Cc: chaoming_li, linville, yongjun_wei, linux-wireless, netdev
On 08/28/2012 08:11 AM, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Remove pointless conditional before kfree_skb().
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> drivers/net/wireless/rtlwifi/rtl8192de/fw.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Acked-by: Larry Finger <Larry.Finger.net>
Thanks,
Larry
>
> diff --git a/drivers/net/wireless/rtlwifi/rtl8192de/fw.c b/drivers/net/wireless/rtlwifi/rtl8192de/fw.c
> index 895ae6c..a3aede0 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8192de/fw.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8192de/fw.c
> @@ -570,8 +570,7 @@ static bool _rtl92d_cmd_send_packet(struct ieee80211_hw *hw,
>
> ring = &rtlpci->tx_ring[BEACON_QUEUE];
> pskb = __skb_dequeue(&ring->queue);
> - if (pskb)
> - kfree_skb(pskb);
> + kfree_skb(pskb);
> spin_lock_irqsave(&rtlpriv->locks.irq_th_lock, flags);
> pdesc = &ring->desc[idx];
> /* discard output from call below */
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-08-28 14:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-28 13:11 [PATCH] rtlwifi: rtl8192de: remove pointless conditional before kfree_skb() Wei Yongjun
2012-08-28 14:44 ` Larry Finger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).