From: Gertjan van Wingerde <gwingerde@gmail.com>
To: Ivo Van Doorn <ivdoorn@gmail.com>
Cc: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
users@rt2x00.serialmonkey.com,
Helmut Schaa <helmut.schaa@googlemail.com>
Subject: Re: [PATCH v2 6/6] rt2x00: rt2800 - Make probe_hw function common between PCI and USB.
Date: Mon, 03 Sep 2012 03:23:46 +0200 [thread overview]
Message-ID: <504406A2.7000303@gmail.com> (raw)
In-Reply-To: <CAOZOX0UvKHoPrcQ8C15eeogknFexBmb1qeiGb0PC52nKMri=JQ@mail.gmail.com>
On 09/02/12 22:44, Ivo Van Doorn wrote:
> Hi,
>
>> diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
>> index c3cae1d..2ad3b7a 100644
>> --- a/drivers/net/wireless/rt2x00/rt2800lib.c
>> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c
>> @@ -44,6 +44,13 @@
>> #include "rt2800.h"
>>
>> /*
>> + * Allow hardware encryption to be disabled.
>> + */
>> +static bool modparam_nohwcrypt = false;
>> +module_param_named(nohwcrypt, modparam_nohwcrypt, bool, S_IRUGO);
>> +MODULE_PARM_DESC(nohwcrypt, "Disable hardware encryption.");
>
> I am not particularly fond of this change, I would like to have the
> module parameters inside the actual drivers instead of inside one of
> the
> library modules. I don't know if there is a policy for modules which
> says something about these situations, but my preference would be
> that the module parameters are inside rt2800pci and rt2800usb, and
> that the value would be passed to rt2800lib.
>
> If there is isn't a simple and clean way to do that, then we can take
> this patch though...
>
Yeah, I wasn't a big fan of that part as well, but at the time couldn't
find a better solution. I do have a better solution now, though.
v3 of this patch will be posted soon.
---
Gertjan
next prev parent reply other threads:[~2012-09-03 1:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-31 17:22 [PATCH v2 0/6] GPIO related fixes and clean ups Gertjan van Wingerde
2012-08-31 17:22 ` [PATCH v2 1/6] rt2x00: Identify ASUS USB-N53 device Gertjan van Wingerde
2012-08-31 17:22 ` [PATCH v2 2/6] rt2x00: Fix word size of rt2500usb MAC_CSR19 register Gertjan van Wingerde
2012-08-31 17:22 ` [PATCH v2 3/6] rt2x00: Fix rfkill polling prior to interface start Gertjan van Wingerde
2012-08-31 17:22 ` [PATCH v2 4/6] rt2x00: Align GPIO register definitions with the datasheets Gertjan van Wingerde
2012-08-31 17:22 ` [PATCH v2 5/6] rt2x00: Unify GPIO register field namings Gertjan van Wingerde
2012-08-31 17:22 ` [PATCH v2 6/6] rt2x00: rt2800 - Make probe_hw function common between PCI and USB Gertjan van Wingerde
2012-09-02 20:44 ` Ivo Van Doorn
2012-09-03 1:23 ` Gertjan van Wingerde [this message]
2012-09-02 20:40 ` [PATCH v2 5/6] rt2x00: Unify GPIO register field namings Ivo Van Doorn
2012-09-02 20:39 ` [PATCH v2 4/6] rt2x00: Align GPIO register definitions with the datasheets Ivo Van Doorn
2012-09-02 20:39 ` [PATCH v2 3/6] rt2x00: Fix rfkill polling prior to interface start Ivo Van Doorn
2012-09-02 20:37 ` [PATCH v2 2/6] rt2x00: Fix word size of rt2500usb MAC_CSR19 register Ivo Van Doorn
2012-09-02 20:37 ` [PATCH v2 1/6] rt2x00: Identify ASUS USB-N53 device Ivo Van Doorn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504406A2.7000303@gmail.com \
--to=gwingerde@gmail.com \
--cc=helmut.schaa@googlemail.com \
--cc=ivdoorn@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=users@rt2x00.serialmonkey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).